Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1149)

Unified Diff: chrome_frame/urlmon_url_request.h

Issue 456013: Fix a crash caused by a race condition between the time the UrlmonUrlRequest:... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome_frame/urlmon_url_request.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/urlmon_url_request.h
===================================================================
--- chrome_frame/urlmon_url_request.h (revision 33288)
+++ chrome_frame/urlmon_url_request.h (working copy)
@@ -119,6 +119,7 @@
void StartAsync();
void StopAsync();
void ReadAsync(int bytes_to_read);
+ void ReleaseBindings();
static const size_t kCopyChunkSize = 32 * 1024;
// URL requests are handled on this thread.
@@ -236,6 +237,10 @@
};
HRESULT StartAsyncDownload();
+ // Sends over the response end notification to chrome, releases the bindings
+ // and releases the initial reference on the UrlmonUrlRequest object.
+ // After this function is called we should not attempt to access any members
+ // as the object could become invalid at any point.
void EndRequest();
// Executes in the context of the UI thread and releases the outstanding
// reference to us. It also deletes the request mapping for this instance.
« no previous file with comments | « no previous file | chrome_frame/urlmon_url_request.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698