Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2063)

Issue 456003002: Open source Histogram.Inconsisten* histograms. (Closed)

Created:
6 years, 4 months ago by Alexei Svitkine (slow)
Modified:
6 years, 4 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Open source Histogram.Inconsisten* histograms. Also sets myself as the owner for these. BUG=223859 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289016

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 2 chunks +137 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Alexei Svitkine (slow)
Corresponding CL: http://CL/72929023
6 years, 4 months ago (2014-08-08 22:13:23 UTC) #1
Ilya Sherman
https://codereview.chromium.org/456003002/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/456003002/diff/20001/tools/metrics/histograms/histograms.xml#newcode9171 tools/metrics/histograms/histograms.xml:9171: +</histogram> I don't see this histogram being removed from ...
6 years, 4 months ago (2014-08-12 00:38:47 UTC) #2
Alexei Svitkine (slow)
https://codereview.chromium.org/456003002/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/456003002/diff/20001/tools/metrics/histograms/histograms.xml#newcode9171 tools/metrics/histograms/histograms.xml:9171: +</histogram> On 2014/08/12 00:38:46, Ilya Sherman wrote: > I ...
6 years, 4 months ago (2014-08-12 14:25:05 UTC) #3
Ilya Sherman
LGTM, thanks.
6 years, 4 months ago (2014-08-12 17:23:00 UTC) #4
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 4 months ago (2014-08-12 17:23:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/456003002/40001
6 years, 4 months ago (2014-08-12 17:24:41 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 17:28:18 UTC) #7
Message was sent while issue was closed.
Change committed as 289016

Powered by Google App Engine
This is Rietveld 408576698