Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Unified Diff: test/mjsunit/regress/regress-2615.js

Issue 455933002: Remove SmartMove, bringing Array methods further into spec compliance (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fix regress-crbug-412319.js to avoid throwing Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/mjsunit/bugs/bug-2615.js ('k') | test/mjsunit/regress/regress-crbug-412319.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/regress/regress-2615.js
diff --git a/test/mjsunit/bugs/bug-2615.js b/test/mjsunit/regress/regress-2615.js
similarity index 87%
copy from test/mjsunit/bugs/bug-2615.js
copy to test/mjsunit/regress/regress-2615.js
index 51aeaf49244d858083d3975d9b39fe66789ff9f8..184a6098d956f6d121bc259cad6fed7630e1b0a0 100644
--- a/test/mjsunit/bugs/bug-2615.js
+++ b/test/mjsunit/regress/regress-2615.js
@@ -25,6 +25,7 @@
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+/* These tests should pass now but they take too long to run.
var a = [];
a[0xfffffffe] = 10;
assertThrows("a.unshift(1);", RangeError);
@@ -38,6 +39,7 @@ assertThrows("a.splice(1,1,7,7,7,7,7);", RangeError);
assertEquals([1,7,7,7,7,7,3], a.slice(0, 7));
assertEquals(0xffffffff, a.length);
assertEquals(10, a[0xfffffffe + 5 - 1]);
+*/
a = [1];
Object.defineProperty(a, "1", {writable:false, configurable:false, value: 100});
@@ -77,7 +79,7 @@ assertEquals(false, desc.configurable);
a = [0,1,2,3,4,5,6];
Object.defineProperty(a, "3", {configurable:false, writable:false, value:3});
assertThrows("a.splice(1,4);", TypeError);
-assertEquals([0,5,6,3,,,,,], a);
+assertEquals([0,5,6,3,,,,], a);
desc = Object.getOwnPropertyDescriptor(a, "3");
assertEquals(false, desc.configurable);
assertEquals(false, desc.writable);
@@ -85,7 +87,7 @@ assertEquals(false, desc.writable);
a = [0,1,2,3,4,5,6];
Object.defineProperty(a, "5", {configurable:false, value:5});
assertThrows("a.splice(1,4);", TypeError);
-assertEquals([0,5,6,3,4,5,,,], a);
+assertEquals([0,5,6,3,4,5,,], a);
desc = Object.getOwnPropertyDescriptor(a, "5");
assertEquals(false, desc.configurable);
@@ -108,19 +110,3 @@ assertThrows("a.pop();", TypeError);
assertEquals([1,2,3], a);
desc = Object.getOwnPropertyDescriptor(a, "2");
assertEquals(false, desc.configurable);
-
-a = [1,2,,,5];
-Object.defineProperty(a, "4", {writable:true, configurable:false, value:5});
-assertThrows("a.sort();", TypeError);
-assertEquals([1,2,5,,5], a);
-desc = Object.getOwnPropertyDescriptor(a, "2");
-assertEquals(true, desc.configurable);
-desc = Object.getOwnPropertyDescriptor(a, "4");
-assertEquals(false, desc.configurable);
-
-a = [1,2,3,,5,6];
-Object.defineProperty(a, "4", {value:5, writable:false});
-assertThrows("a.sort();", TypeError);
-assertEquals([1,2,3,5,5,6], a);
-desc = Object.getOwnPropertyDescriptor(a, "4");
-assertEquals(false, desc.writable);
« no previous file with comments | « test/mjsunit/bugs/bug-2615.js ('k') | test/mjsunit/regress/regress-crbug-412319.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698