Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 455903002: Replace a pre-UAL instruction with its modern form. (Closed)

Created:
6 years, 4 months ago by Nico
Modified:
6 years, 4 months ago
Reviewers:
djsollen, mtklein
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Replace a pre-UAL instruction with its modern form. See the notes in the Chromium bug, and http://llvm.org/20427 BUG=chromium:124610, skia:900 Committed: https://skia.googlesource.com/skia/+/81cc04d0a6f1d841da75c30e3ff3cc2437d35935

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/opts/memset16_neon.S View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Nico
6 years, 4 months ago (2014-08-08 18:17:32 UTC) #1
Nico
Patch set 2 even works with gcc too, sorry for not checking that earlier.
6 years, 4 months ago (2014-08-08 23:57:05 UTC) #2
Nico
ping
6 years, 4 months ago (2014-08-11 16:10:45 UTC) #3
mtklein
lgtm
6 years, 4 months ago (2014-08-11 16:44:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/thakis@chromium.org/455903002/20001
6 years, 4 months ago (2014-08-11 16:45:09 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-11 16:52:40 UTC) #6
Message was sent while issue was closed.
Change committed as 81cc04d0a6f1d841da75c30e3ff3cc2437d35935

Powered by Google App Engine
This is Rietveld 408576698