Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 455883003: Cleanup namespace usage in public/web/Web[A-M]*.h. (Closed)

Created:
6 years, 4 months ago by tkent
Modified:
6 years, 4 months ago
Reviewers:
keishi, abarth-chromium
CC:
abarth-chromium, aandrey+blink_chromium.org, apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, dglazkov+blink, eric.carlson_apple.com, eustas+blink_chromium.org, feature-media-reviews_chromium.org, jamesr, kinuko+fileapi, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, mvanouwerkerk+watch_chromium.org, nhiroki, paulirish+reviews_chromium.org, pfeldman+blink_chromium.org, philipj_slow, sergeyv+blink_chromium.org, timvolodine, tzik, vsevik+blink_chromium.org, yurys+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Cleanup namespace usage in public/web/Web[A-M]*.h. - Merge multiple |namespace blink {}| blocks - Remove unnecessary blink:: prefixes - Make blank lines consistent BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179889

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -170 lines) Patch
M public/web/WebAXObject.h View 2 chunks +5 lines, -6 lines 0 comments Download
M public/web/WebBlob.h View 2 chunks +5 lines, -5 lines 0 comments Download
M public/web/WebCachedURLRequest.h View 2 chunks +3 lines, -4 lines 0 comments Download
M public/web/WebColorSuggestion.h View 1 chunk +3 lines, -5 lines 0 comments Download
M public/web/WebDOMError.h View 2 chunks +5 lines, -5 lines 0 comments Download
M public/web/WebDOMEvent.h View 4 chunks +6 lines, -5 lines 0 comments Download
M public/web/WebDOMFileSystem.h View 2 chunks +5 lines, -5 lines 0 comments Download
M public/web/WebDOMMediaStreamTrack.h View 2 chunks +4 lines, -4 lines 0 comments Download
M public/web/WebDOMMessageEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M public/web/WebDOMMouseEvent.h View 1 chunk +0 lines, -4 lines 0 comments Download
M public/web/WebDatabase.h View 2 chunks +3 lines, -4 lines 0 comments Download
M public/web/WebDateTimeSuggestion.h View 2 chunks +4 lines, -6 lines 0 comments Download
M public/web/WebDevToolsAgent.h View 1 chunk +1 line, -0 lines 0 comments Download
M public/web/WebDevToolsAgentClient.h View 1 chunk +1 line, -0 lines 0 comments Download
M public/web/WebDocument.h View 3 chunks +6 lines, -7 lines 0 comments Download
M public/web/WebDocumentType.h View 2 chunks +5 lines, -4 lines 0 comments Download
M public/web/WebElement.h View 2 chunks +5 lines, -7 lines 0 comments Download
M public/web/WebElementCollection.h View 2 chunks +5 lines, -4 lines 0 comments Download
M public/web/WebFontDescription.h View 2 chunks +4 lines, -7 lines 0 comments Download
M public/web/WebFormControlElement.h View 2 chunks +5 lines, -7 lines 0 comments Download
M public/web/WebFormElement.h View 2 chunks +6 lines, -9 lines 0 comments Download
M public/web/WebFrameClient.h View 1 chunk +1 line, -1 line 0 comments Download
M public/web/WebGeolocationClient.h View 1 chunk +1 line, -0 lines 0 comments Download
M public/web/WebGeolocationController.h View 3 chunks +3 lines, -4 lines 0 comments Download
M public/web/WebGeolocationError.h View 2 chunks +5 lines, -6 lines 0 comments Download
M public/web/WebGeolocationPermissionRequest.h View 2 chunks +5 lines, -6 lines 0 comments Download
M public/web/WebGeolocationPermissionRequestManager.h View 1 chunk +3 lines, -3 lines 0 comments Download
M public/web/WebGeolocationPosition.h View 2 chunks +6 lines, -6 lines 0 comments Download
M public/web/WebHistoryItem.h View 2 chunks +6 lines, -6 lines 0 comments Download
M public/web/WebHitTestResult.h View 2 chunks +3 lines, -6 lines 0 comments Download
M public/web/WebIconURL.h View 1 chunk +1 line, -1 line 0 comments Download
M public/web/WebImageDecoder.h View 1 chunk +2 lines, -3 lines 0 comments Download
M public/web/WebInputElement.h View 2 chunks +5 lines, -8 lines 0 comments Download
M public/web/WebLabelElement.h View 2 chunks +5 lines, -4 lines 0 comments Download
M public/web/WebMIDIClient.h View 1 chunk +1 line, -0 lines 0 comments Download
M public/web/WebMIDIClientMock.h View 2 chunks +2 lines, -4 lines 0 comments Download
M public/web/WebMIDIPermissionRequest.h View 2 chunks +4 lines, -7 lines 0 comments Download
M public/web/WebMediaDevicesRequest.h View 2 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tkent
Please review this.
6 years, 4 months ago (2014-08-08 23:39:04 UTC) #1
abarth-chromium
lgtm
6 years, 4 months ago (2014-08-09 19:00:45 UTC) #2
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 4 months ago (2014-08-09 21:53:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/455883003/1
6 years, 4 months ago (2014-08-09 21:54:25 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-09 21:57:34 UTC) #5
Message was sent while issue was closed. 
Change committed as 179889

Powered by Google App Engine
This is Rietveld 408576698