Fixing bug in RecordingImageBufferSurface::writePixels when using DisplayList2DCanvas

Calling writePixels on a canvas using DisplayList2DCanvas was ignoring the call (canvas.pixels == null)
To make this work, we need to fallback to a raster canvas to be able to directly access the canvas' pixels.

To be more consistent, the method willReadback has be renamed to willAccessPixels.

Fixes the following layout-tests with --enable-display-list-2d-canvas:
  fast/canvas/canvas-imageSmoothingEnabled.html [ Failure ]
  fast/canvas/canvas-putImageData.html [ Failure ]
  fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgb565.html [ Failure ]
  fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgba4444.html [ Failure ]
  fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgba5551.html [ Failure ]
  fast/canvas/webgl/tex-image-and-sub-image-2d-with-image.html [ Failure ]
  fast/canvas/canvas-imageSmoothingEnabled-patterns.html [ ImageOnlyFailure ]

BUG=401624
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179969

[Rémi Piotaix, 2014-08-08 14:45:58]

PTAL

[Justin Novosad, 2014-08-08 15:00:08]

lgtm for the code, but please make the summary more readable and add a
description explaining why this change fixes the bug.

[Rémi Piotaix, 2014-08-08 15:20:23]

On 2014/08/08 15:00:08, junov wrote:
> lgtm for the code, but please make the summary more readable and add a
> description explaining why this change fixes the bug.

Better this way ?

[Justin Novosad, 2014-08-08 19:48:57]

On 2014/08/08 15:20:23, Rémi Piotaix wrote:
> On 2014/08/08 15:00:08, junov wrote:
> > lgtm for the code, but please make the summary more readable and add a
> > description explaining why this change fixes the bug.
> 
> Better this way ?

Almost. please indicate which layout test this fixes.

[Rémi Piotaix, 2014-08-08 21:34:05]

On 2014/08/08 19:48:57, junov wrote:
> On 2014/08/08 15:20:23, Rémi Piotaix wrote:
> > On 2014/08/08 15:00:08, junov wrote:
> > > lgtm for the code, but please make the summary more readable and add a
> > > description explaining why this change fixes the bug.
> > 
> > Better this way ?
> 
> Almost. please indicate which layout test this fixes.

Done :-)

[Justin Novosad, 2014-08-09 01:26:04]

The CQ bit was checked by junov@chromium.org

[commit-bot: I haz the power, 2014-08-09 01:26:41]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/piotaixr@chromium.org/455863002/1

[commit-bot: I haz the power, 2014-08-09 01:26:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-09 01:26:51]

Failed to apply patch for Source/platform/graphics/Canvas2DImageBufferSurface.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/platform/graphics/Canvas2DImageBufferSurface.h
  Hunk #1 FAILED at 54.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/platform/graphics/Canvas2DImageBufferSurface.h.rej

Patch:       Source/platform/graphics/Canvas2DImageBufferSurface.h
Index: Source/platform/graphics/Canvas2DImageBufferSurface.h
diff --git a/Source/platform/graphics/Canvas2DImageBufferSurface.h
b/Source/platform/graphics/Canvas2DImageBufferSurface.h
index
7bb0ebc658f8bd497d4028f91c5ea22c97b45a9c..07a59ba9f6b4846e67beb6ae540776f17aeee5ca
100644
--- a/Source/platform/graphics/Canvas2DImageBufferSurface.h
+++ b/Source/platform/graphics/Canvas2DImageBufferSurface.h
@@ -54,7 +54,7 @@ public:
 
     // ImageBufferSurface implementation
     virtual void didDraw() OVERRIDE { m_layerBridge->didDraw(); }
-    virtual void willReadback() OVERRIDE { m_layerBridge->willReadback(); }
+    virtual void willAccessPixels() OVERRIDE {
m_layerBridge->willAccessPixels(); }
     virtual SkCanvas* canvas() const OVERRIDE { return m_layerBridge->canvas();
}
     virtual bool isValid() const OVERRIDE { return m_layerBridge &&
m_layerBridge->checkSurfaceValid(); }
     virtual bool restore() OVERRIDE { return m_layerBridge->restoreSurface(); }

[Rémi Piotaix, 2014-08-11 15:45:35]

The CQ bit was checked by piotaixr@chromium.org

[commit-bot: I haz the power, 2014-08-11 15:46:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/piotaixr@chromium.org/455863002/20001

[commit-bot: I haz the power, 2014-08-11 16:48:04]

Change committed as 179969