Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 455833005: Fixes bug in GinJavaBridgeDispatcherHost (Closed)

Created:
6 years, 4 months ago by sky
Modified:
6 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

Fixes bug in GinJavaBridgeDispatcherHost My try job kept failing on android and I finally tracked it down to this code. GinJavaBridgeDispatcherHost::RemoveNamedObject may be invoked with a value that comes from named_objects_ (see AddNamedObject). RemoveNamedObject removes from named_object_ and then uses the passed in value. If this happens |name| is no longer valid and shouldn't be used. BUG=none TEST=none R=mnaganov@chromium.org TBR=mnaganov@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288861

Patch Set 1 #

Patch Set 2 : %r #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M content/browser/android/java/gin_java_bridge_dispatcher_host.cc View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
sky
6 years, 4 months ago (2014-08-11 19:33:25 UTC) #1
mnaganov (inactive)
Good catch! Sorry for causing a trouble.
6 years, 4 months ago (2014-08-11 20:02:47 UTC) #2
sky
The CQ bit was checked by sky@chromium.org
6 years, 4 months ago (2014-08-11 20:03:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/455833005/1
6 years, 4 months ago (2014-08-11 20:04:22 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-11 20:04:23 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-08-11 20:04:24 UTC) #6
sky
I'm TBRing so this'll land. This feels fine to me as you wrote the code, ...
6 years, 4 months ago (2014-08-11 21:28:55 UTC) #7
sky
The CQ bit was checked by sky@chromium.org
6 years, 4 months ago (2014-08-11 21:28:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/455833005/1
6 years, 4 months ago (2014-08-11 21:33:02 UTC) #9
sky
The CQ bit was checked by sky@chromium.org
6 years, 4 months ago (2014-08-11 22:17:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/455833005/20001
6 years, 4 months ago (2014-08-11 22:23:56 UTC) #11
commit-bot: I haz the power
Change committed as 288861
6 years, 4 months ago (2014-08-12 01:28:37 UTC) #12
mnaganov (inactive)
6 years, 4 months ago (2014-08-12 08:23:13 UTC) #13
Message was sent while issue was closed.
On 2014/08/12 01:28:37, I haz the power (commit-bot) wrote:
> Change committed as 288861

My bad. I really meant LGTM when replying, but forgot to actually type it.
Sorry, and thanks again for the fix!

Powered by Google App Engine
This is Rietveld 408576698