Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Unified Diff: gpu/command_buffer/common/gles2_cmd_utils.h

Issue 455783002: GPU context creation code duplication cleanup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Fix even more build dependencies Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/client/share_group.h ('k') | gpu/command_buffer/common/gles2_cmd_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/common/gles2_cmd_utils.h
diff --git a/gpu/command_buffer/common/gles2_cmd_utils.h b/gpu/command_buffer/common/gles2_cmd_utils.h
index 15f3b57e0a5516cef7ddf1882b95c00c53efa832..163ffc008c206f1edb1674d7f321d238299ef10c 100644
--- a/gpu/command_buffer/common/gles2_cmd_utils.h
+++ b/gpu/command_buffer/common/gles2_cmd_utils.h
@@ -196,27 +196,25 @@ class GLES2_UTILS_EXPORT GLES2Util {
int num_shader_binary_formats_;
};
-class GLES2_UTILS_EXPORT ContextCreationAttribHelper {
- public:
+struct GLES2_UTILS_EXPORT ContextCreationAttribHelper {
ContextCreationAttribHelper();
- void Serialize(std::vector<int32_t>* attribs);
+ void Serialize(std::vector<int32_t>* attribs) const;
bool Parse(const std::vector<int32_t>& attribs);
// -1 if invalid or unspecified.
- int32_t alpha_size_;
- int32_t blue_size_;
- int32_t green_size_;
- int32_t red_size_;
- int32_t depth_size_;
- int32_t stencil_size_;
- int32_t samples_;
- int32_t sample_buffers_;
- bool buffer_preserved_;
- bool share_resources_;
- bool bind_generates_resource_;
- bool fail_if_major_perf_caveat_;
- bool lose_context_when_out_of_memory_;
+ int32_t alpha_size;
+ int32_t blue_size;
+ int32_t green_size;
+ int32_t red_size;
+ int32_t depth_size;
+ int32_t stencil_size;
+ int32_t samples;
+ int32_t sample_buffers;
+ bool buffer_preserved;
+ bool bind_generates_resource;
+ bool fail_if_major_perf_caveat;
+ bool lose_context_when_out_of_memory;
};
} // namespace gles2
« no previous file with comments | « gpu/command_buffer/client/share_group.h ('k') | gpu/command_buffer/common/gles2_cmd_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698