Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Unified Diff: gpu/command_buffer/client/gl_in_process_context.h

Issue 455783002: GPU context creation code duplication cleanup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Fix even more build dependencies Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/client/BUILD.gn ('k') | gpu/command_buffer/client/gl_in_process_context.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/client/gl_in_process_context.h
diff --git a/gpu/command_buffer/client/gl_in_process_context.h b/gpu/command_buffer/client/gl_in_process_context.h
index 6c3a485972b604e6530fc5b79a37d2645f3e01d1..6175cc556ad284f9522cacbd9ced80c7796798d1 100644
--- a/gpu/command_buffer/client/gl_in_process_context.h
+++ b/gpu/command_buffer/client/gl_in_process_context.h
@@ -8,6 +8,7 @@
#include "base/callback.h"
#include "base/compiler_specific.h"
#include "gl_in_process_context_export.h"
+#include "gpu/command_buffer/common/gles2_cmd_utils.h"
#include "gpu/command_buffer/service/in_process_command_buffer.h"
#include "ui/gfx/native_widget_types.h"
#include "ui/gl/gl_surface.h"
@@ -29,22 +30,6 @@ namespace gles2 {
class GLES2Implementation;
}
-// The default uninitialized value is -1.
-struct GL_IN_PROCESS_CONTEXT_EXPORT GLInProcessContextAttribs {
- GLInProcessContextAttribs();
-
- int32 alpha_size;
- int32 blue_size;
- int32 green_size;
- int32 red_size;
- int32 depth_size;
- int32 stencil_size;
- int32 samples;
- int32 sample_buffers;
- int32 fail_if_major_perf_caveat;
- int32 lose_context_when_out_of_memory;
-};
-
class GL_IN_PROCESS_CONTEXT_EXPORT GLInProcessContext {
public:
virtual ~GLInProcessContext() {}
@@ -67,7 +52,7 @@ class GL_IN_PROCESS_CONTEXT_EXPORT GLInProcessContext {
const gfx::Size& size,
GLInProcessContext* share_context,
bool use_global_share_group,
- const GLInProcessContextAttribs& attribs,
+ const gpu::gles2::ContextCreationAttribHelper& attribs,
gfx::GpuPreference gpu_preference);
virtual void SetContextLostCallback(const base::Closure& callback) = 0;
« no previous file with comments | « gpu/command_buffer/client/BUILD.gn ('k') | gpu/command_buffer/client/gl_in_process_context.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698