Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1837)

Unified Diff: content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h

Issue 455783002: GPU context creation code duplication cleanup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Fix even more build dependencies Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h
diff --git a/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h b/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h
index 67a4fa2718bc6c40a05621491476e23bab708ac3..9aebaf0ce1fc89bef4c00d5a1985de5d88192639 100644
--- a/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h
+++ b/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h
@@ -161,30 +161,6 @@ class WebGraphicsContext3DCommandBufferImpl
BAD_ATTRIBUTE = 0x3004,
CONTEXT_LOST = 0x300E
};
- // WebGraphicsContext3DCommandBufferImpl configuration attributes. Those in
- // the 16-bit range are the same as used by EGL. Those outside the 16-bit
- // range are unique to Chromium. Attributes are matched using a closest fit
- // algorithm.
- // Changes to this enum should also be copied to
- // gpu/command_buffer/common/gles2_cmd_utils.cc and to
- // gpu/command_buffer/client/gl_in_process_context.cc
- enum Attribute {
- ALPHA_SIZE = 0x3021,
- BLUE_SIZE = 0x3022,
- GREEN_SIZE = 0x3023,
- RED_SIZE = 0x3024,
- DEPTH_SIZE = 0x3025,
- STENCIL_SIZE = 0x3026,
- SAMPLES = 0x3031,
- SAMPLE_BUFFERS = 0x3032,
- HEIGHT = 0x3056,
- WIDTH = 0x3057,
- NONE = 0x3038, // Attrib list = terminator
- SHARE_RESOURCES = 0x10000,
- BIND_GENERATES_RESOURCES = 0x10001,
- FAIL_IF_MAJOR_PERF_CAVEAT = 0x10002,
- LOSE_CONTEXT_WHEN_OUT_OF_MEMORY = 0x10003,
- };
// Initialize the underlying GL context. May be called multiple times; second
// and subsequent calls are ignored. Must be called from the thread that is

Powered by Google App Engine
This is Rietveld 408576698