GPU context creation code duplication cleanup

gpu/command_buffer/common/gles2_cmd_utils.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file is here so other GLES2 related files can have a common set of
 // includes where appropriate.
 
 #ifndef GPU_COMMAND_BUFFER_COMMON_GLES2_CMD_UTILS_H_
 #define GPU_COMMAND_BUFFER_COMMON_GLES2_CMD_UTILS_H_
 
@@ skipping 178 matching lines @@
   static std::string GetQualifiedEnumString(
       const EnumToString* table, size_t count, uint32_t value);
 
   static const EnumToString* const enum_to_string_table_;
   static const size_t enum_to_string_table_len_;
 
   int num_compressed_texture_formats_;
   int num_shader_binary_formats_;
 };
 
 class GLES2_UTILS_EXPORT ContextCreationAttribHelper {

[Zhenyao Mo, 2014/08/09 00:42:25]

Since you are cleaning things up in this: this should be a struct rather than
class, and all members should be named alpha_size instead of alpha_size_, etc.

  public:
   ContextCreationAttribHelper();
 
-  void Serialize(std::vector<int32_t>* attribs);
+  void Serialize(std::vector<int32_t>* attribs) const;
   bool Parse(const std::vector<int32_t>& attribs);
 
   // -1 if invalid or unspecified.
   int32_t alpha_size_;
   int32_t blue_size_;
   int32_t green_size_;
   int32_t red_size_;
   int32_t depth_size_;
   int32_t stencil_size_;
   int32_t samples_;
   int32_t sample_buffers_;
   bool buffer_preserved_;
-  bool share_resources_;
   bool bind_generates_resource_;
   bool fail_if_major_perf_caveat_;
   bool lose_context_when_out_of_memory_;
 };
 
 }  // namespace gles2
 }  // namespace gpu
 
 #endif  // GPU_COMMAND_BUFFER_COMMON_GLES2_CMD_UTILS_H_