Issue 455773003: athena: Show the theme-color in the title strip, and fix the height.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 455773003: athena: Show the theme-color in the title strip, and fix the height. (Closed)

Created:
6 years, 4 months ago by sadrul

Modified:
6 years, 4 months ago

Reviewers:
oshima

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

athena: Show the theme-color in the title strip, and fix the height. If the web-page specifies a color using the 'theme-color' meta-tag, then use that color to paint the background of the window-title. Fix the height of the title to be 25px. BUG=401569 R=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288420

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -2 lines)			Patch
M	athena/activity/activity_frame_view.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	athena/content/web_activity.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	athena/content/web_activity.cc	View		4 chunks	+9 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

sadrul

6 years, 4 months ago (2014-08-08 20:02:49 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as 288420 (presubmit successful).