Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 455773002: Create "Paint profiler" experiment (Closed)

Created:
6 years, 4 months ago by yurys
Modified:
6 years, 4 months ago
Reviewers:
caseq, alph, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Create "Paint profiler" experiment In preparation to moving "Timeline on traced events" out of experimentat created a separate experiment for "Paint profiler". BUG=399531 R=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179830

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M Source/devtools/front_end/common/Settings.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 1 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yurys
6 years, 4 months ago (2014-08-08 12:28:40 UTC) #1
pfeldman
https://codereview.chromium.org/455773002/diff/1/Source/devtools/front_end/timeline/TimelinePanel.js File Source/devtools/front_end/timeline/TimelinePanel.js (right): https://codereview.chromium.org/455773002/diff/1/Source/devtools/front_end/timeline/TimelinePanel.js#newcode408 Source/devtools/front_end/timeline/TimelinePanel.js:408: WebInspector.experimentsSettings.paintProfiler.isEnabled()) { You want to hide layers behind experiment ...
6 years, 4 months ago (2014-08-08 12:32:21 UTC) #2
yurys
https://codereview.chromium.org/455773002/diff/1/Source/devtools/front_end/timeline/TimelinePanel.js File Source/devtools/front_end/timeline/TimelinePanel.js (right): https://codereview.chromium.org/455773002/diff/1/Source/devtools/front_end/timeline/TimelinePanel.js#newcode408 Source/devtools/front_end/timeline/TimelinePanel.js:408: WebInspector.experimentsSettings.paintProfiler.isEnabled()) { On 2014/08/08 12:32:21, pfeldman wrote: > You ...
6 years, 4 months ago (2014-08-08 12:58:06 UTC) #3
pfeldman
lgtm
6 years, 4 months ago (2014-08-08 13:01:09 UTC) #4
yurys
6 years, 4 months ago (2014-08-08 13:27:50 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 manually as 179830 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698