Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 455683002: Fix debug-promises tests. (Closed)

Created:
6 years, 4 months ago by Yang
Modified:
6 years, 4 months ago
Reviewers:
rossberg
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix debug-promises tests. Using assertEquals on two Promises always passes. Use assertSame instead. R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22995

Patch Set 1 #

Messages

Total messages: 3 (0 generated)
Yang
6 years, 4 months ago (2014-08-08 07:37:07 UTC) #1
rossberg
lgtm
6 years, 4 months ago (2014-08-08 11:14:44 UTC) #2
Yang
6 years, 4 months ago (2014-08-08 11:58:02 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 22995 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698