Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 455653002: Use single quotes in Layout tests as they don't need to be escaped (Closed)

Created:
6 years, 4 months ago by Sunil Ratnu
Modified:
6 years, 4 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, benquan, Dane Wallinga, dyu1, mkwst+watchlist_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Use single quotes in Layout tests as they don't need to be escaped Using single quotes instead of double quotes as single quotes don't need to be escaped. This helps in maintaining a consistency throughout Layout tests. R=isherman@chromium.org BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288618

Patch Set 1 #

Patch Set 2 : Fix failing tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+418 lines, -418 lines) Patch
M chrome/renderer/autofill/autofill_renderer_browsertest.cc View 5 chunks +15 lines, -15 lines 0 comments Download
M chrome/renderer/autofill/form_autofill_browsertest.cc View 1 76 chunks +403 lines, -403 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Sunil Ratnu
Hi Ilya, A minor cleanup. PTAL.
6 years, 4 months ago (2014-08-08 05:45:33 UTC) #1
Ilya Sherman
LGTM. Thanks for the cleanup :)
6 years, 4 months ago (2014-08-08 07:00:20 UTC) #2
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 4 months ago (2014-08-08 07:00:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/455653002/1
6 years, 4 months ago (2014-08-08 07:02:24 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-08 12:12:00 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-08 12:49:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/2236)
6 years, 4 months ago (2014-08-08 12:49:47 UTC) #7
Sunil Ratnu
The CQ bit was checked by sunil.ratnu@samsung.com
6 years, 4 months ago (2014-08-09 13:31:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/455653002/20001
6 years, 4 months ago (2014-08-09 13:31:35 UTC) #9
Sunil Ratnu
The CQ bit was unchecked by sunil.ratnu@samsung.com
6 years, 4 months ago (2014-08-09 13:31:48 UTC) #10
Sunil Ratnu
On 2014/08/09 13:31:48, Sunil Ratnu wrote: > The CQ bit was unchecked by mailto:sunil.ratnu@samsung.com Hi ...
6 years, 4 months ago (2014-08-09 13:34:38 UTC) #11
Sunil Ratnu
On 2014/08/09 13:34:38, Sunil Ratnu wrote: > On 2014/08/09 13:31:48, Sunil Ratnu wrote: > > ...
6 years, 4 months ago (2014-08-09 16:32:57 UTC) #12
Sunil Ratnu
The CQ bit was checked by sunil.ratnu@samsung.com
6 years, 4 months ago (2014-08-10 05:11:36 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/455653002/20001
6 years, 4 months ago (2014-08-10 05:12:17 UTC) #14
commit-bot: I haz the power
6 years, 4 months ago (2014-08-10 05:12:56 UTC) #15
Message was sent while issue was closed.
Change committed as 288618

Powered by Google App Engine
This is Rietveld 408576698