Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 455633002: Subzero: Add the "llvm2ice -ffunction-sections" argument. (Closed)

Created:
6 years, 4 months ago by Jim Stichnoth
Modified:
6 years, 4 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://gerrit.chromium.org/gerrit/p/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Subzero: Add the "llvm2ice -ffunction-sections" argument. The purpose is to enable bisection debugging of Subzero-translated functions, using objcopy to selectively splice functions from llc and Subzero into the binary. Note that llvm-mc claims to take this argument, but actually does nothing with it, so we need to implement it in Subzero. Also moves the ClFlags object into the GlobalContext so everyone can access it. BUG= none R=wala@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=989a703

Patch Set 1 #

Patch Set 2 : Clean up some namespace formatting/comments #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -35 lines) Patch
M src/IceCfg.cpp View 2 chunks +4 lines, -1 line 0 comments Download
M src/IceClFlags.h View 1 1 chunk +5 lines, -2 lines 0 comments Download
M src/IceConverter.h View 1 chunk +1 line, -1 line 0 comments Download
M src/IceConverter.cpp View 1 4 chunks +6 lines, -5 lines 0 comments Download
M src/IceGlobalContext.h View 4 chunks +6 lines, -1 line 0 comments Download
M src/IceGlobalContext.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M src/IceIntrinsics.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/IceTranslator.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/IceTranslator.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M src/PNaClTranslator.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/PNaClTranslator.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/llvm2ice.cpp View 3 chunks +9 lines, -4 lines 0 comments Download
M tests_lit/llvm2ice_tests/mangle.ll View 13 chunks +26 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jim Stichnoth
6 years, 4 months ago (2014-08-08 04:35:19 UTC) #1
wala
lgtm
6 years, 4 months ago (2014-08-08 16:42:54 UTC) #2
Jim Stichnoth
6 years, 4 months ago (2014-08-08 17:13:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r989a703 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698