chrome/browser/net/chrome_network_delegate.cc - Issue 455623003: stale-while-revalidate experimental implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/chrome_network_delegate.cc

Issue 455623003: stale-while-revalidate experimental implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/net/chrome_network_delegate.cc

diff --git a/chrome/browser/net/chrome_network_delegate.cc b/chrome/browser/net/chrome_network_delegate.cc

index ca6c04acd42e8495a74f3eb36808ec2a75fc3249..9b9c910db81998eaa76c32a97428d3a80298b849 100644

--- a/chrome/browser/net/chrome_network_delegate.cc

+++ b/chrome/browser/net/chrome_network_delegate.cc

@@ -570,8 +570,10 @@ void ChromeNetworkDelegate::OnCompleted(net::URLRequest* request,

data_reduction_proxy::GetDataReductionProxyRequestType(request);

base::TimeDelta freshness_lifetime =

- request->response_info().headers->GetFreshnessLifetime(

- request->response_info().response_time);

+ request->response_info()

+ .headers->GetFreshnessLifetimes(

+ request->response_info().response_time)

mmenke 2014/10/09 14:29:58 nit: This should use 4-space indent.

+ .fresh;

mmenke 2014/10/09 14:29:58 nit: Think it's more consistent with prevailing s

int64 adjusted_original_content_length =

data_reduction_proxy::GetAdjustedOriginalContentLength(

request_type, original_content_length,