Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 455623002: content: Rename blink_glue.* to file_info_util.*. (Closed)

Created:
6 years, 4 months ago by tfarina
Modified:
6 years, 4 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, darin-cc_chromium.org, jam, kinuko+fileapi, nhiroki, tzik
Project:
chromium
Visibility:
Public.

Description

content: Rename blink_glue.* to file_info_util.*. Reason: blink_glue.* is too generic for this. It just contains a single function to convert from base::File::Info to blink::WebFileInfo. Similar to web_url_request_util.h and pepper_file_util.h. BUG=345892 TEST=None R=avi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288399

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -64 lines) Patch
D content/child/blink_glue.h View 1 chunk +0 lines, -23 lines 0 comments Download
D content/child/blink_glue.cc View 1 chunk +0 lines, -29 lines 0 comments Download
A + content/child/file_info_util.h View 2 chunks +5 lines, -6 lines 0 comments Download
A + content/child/file_info_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/fileapi/webfilesystem_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/webfileutilities_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/content_child.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
trivial, mechanical file move done with tools/git/move_source_file.py
6 years, 4 months ago (2014-08-08 03:36:06 UTC) #1
Avi (use Gerrit)
lgtm Sure.
6 years, 4 months ago (2014-08-08 14:46:19 UTC) #2
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 4 months ago (2014-08-08 17:24:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/455623002/20001
6 years, 4 months ago (2014-08-08 17:25:45 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 18:28:42 UTC) #5
Message was sent while issue was closed.
Change committed as 288399

Powered by Google App Engine
This is Rietveld 408576698