Subzero: Add a random number generator.

Subzero: Add a random number generator.

This is inital work necessary for diversification support in Subzero.
The random number generator implementation is temporary.  It will
eventually use a cryptographically secure pseudorandom number
generator (perhaps from LLVM, if LLVM gets one).

Add the -rng-seed= option to seed the random number generator from
the command line.

BUG=none
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=1bd2fce

[Jim Stichnoth, 2014-08-08 05:05:38]

LGTM with nits.

https://codereview.chromium.org/455593004/diff/1/src/IceGlobalContext.cpp
File src/IceGlobalContext.cpp (right):

https://codereview.chromium.org/455593004/diff/1/src/IceGlobalContext.cpp#new...
src/IceGlobalContext.cpp:34: cl::init(1));
Can you default initialize to time(0) or something like that?

https://codereview.chromium.org/455593004/diff/1/src/IceGlobalContext.h
File src/IceGlobalContext.h (right):

https://codereview.chromium.org/455593004/diff/1/src/IceGlobalContext.h#newco...
src/IceGlobalContext.h:25: #include "IceRNG.h"
alphabetize includes

https://codereview.chromium.org/455593004/diff/1/src/IceGlobalContext.h#newco...
src/IceGlobalContext.h:95: RandomNumberGenerator &getRNG() { return RNG; }
Please add TODOs in appropriate places:

1. Switch to RNG implementation from LLVM or C++11.

2. Make the RNG play nicely with multithreaded translation.

3. Make it possible to replay the RNG sequence in a subsequent run, for
reproducing a bug.  Print the seed/whatever in a comment in the asm output. 
Embed the seed in the binary via metadata that an attacker can't introspect.

[native-client-reviews_googlegroups.com, 2014-08-08 06:15:08]

Could you make sure that the approach take here is the same as in LLVM?


On Thu, Aug 7, 2014 at 10:05 PM, <stichnot@chromium.org> wrote:

> LGTM with nits.
>
>
> https://codereview.chromium.org/455593004/diff/1/src/IceGlobalContext.cpp
> File src/IceGlobalContext.cpp (right):
>
> https://codereview.chromium.org/455593004/diff/1/src/
> IceGlobalContext.cpp#newcode34
> src/IceGlobalContext.cpp:34: cl::init(1));
> Can you default initialize to time(0) or something like that?
>
> https://codereview.chromium.org/455593004/diff/1/src/IceGlobalContext.h
> File src/IceGlobalContext.h (right):
>
> https://codereview.chromium.org/455593004/diff/1/src/
> IceGlobalContext.h#newcode25
> src/IceGlobalContext.h:25: #include "IceRNG.h"
> alphabetize includes
>
> https://codereview.chromium.org/455593004/diff/1/src/
> IceGlobalContext.h#newcode95
> src/IceGlobalContext.h:95: RandomNumberGenerator &getRNG() { return RNG;
> }
> Please add TODOs in appropriate places:
>
> 1. Switch to RNG implementation from LLVM or C++11.
>
> 2. Make the RNG play nicely with multithreaded translation.
>
> 3. Make it possible to replay the RNG sequence in a subsequent run, for
> reproducing a bug.  Print the seed/whatever in a comment in the asm
> output.  Embed the seed in the binary via metadata that an attacker
> can't introspect.
>
> https://codereview.chromium.org/455593004/
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "Native-Client-Reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to native-client-reviews+unsubscribe@googlegroups.com.
> To post to this group, send email to native-client-reviews@
> googlegroups.com.
> Visit this group at http://groups.google.com/group/native-client-reviews.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at http://groups.google.com/group/native-client-reviews.
For more options, visit https://groups.google.com/d/optout.

[wala, 2014-08-08 16:36:13]

https://codereview.chromium.org/455593004/diff/1/src/IceGlobalContext.cpp
File src/IceGlobalContext.cpp (right):

https://codereview.chromium.org/455593004/diff/1/src/IceGlobalContext.cpp#new...
src/IceGlobalContext.cpp:34: cl::init(1));
On 2014/08/08 05:05:38, stichnot wrote:
> Can you default initialize to time(0) or something like that?

Done.

https://codereview.chromium.org/455593004/diff/1/src/IceGlobalContext.h
File src/IceGlobalContext.h (right):

https://codereview.chromium.org/455593004/diff/1/src/IceGlobalContext.h#newco...
src/IceGlobalContext.h:25: #include "IceRNG.h"
On 2014/08/08 05:05:38, stichnot wrote:
> alphabetize includes

Done.

https://codereview.chromium.org/455593004/diff/1/src/IceGlobalContext.h#newco...
src/IceGlobalContext.h:95: RandomNumberGenerator &getRNG() { return RNG; }
On 2014/08/08 05:05:38, stichnot wrote:
> Please add TODOs in appropriate places:
> 
> 1. Switch to RNG implementation from LLVM or C++11.
> 
> 2. Make the RNG play nicely with multithreaded translation.
> 
> 3. Make it possible to replay the RNG sequence in a subsequent run, for
> reproducing a bug.  Print the seed/whatever in a comment in the asm output. 
> Embed the seed in the binary via metadata that an attacker can't introspect.

Done.

[wala, 2014-08-08 16:37:04]

I've changed the interface to be the same as LLVM's random number generator.
It's also used the same way (present in IceGlobalContext).

On 2014/08/08 06:15:08, native-client-reviews_googlegroups.com wrote:
> Could you make sure that the approach take here is the same as in LLVM?
> 
> 
> On Thu, Aug 7, 2014 at 10:05 PM, <mailto:stichnot@chromium.org> wrote:
> 
> > LGTM with nits.
> >
> >
> > https://codereview.chromium.org/455593004/diff/1/src/IceGlobalContext.cpp
> > File src/IceGlobalContext.cpp (right):
> >
> > https://codereview.chromium.org/455593004/diff/1/src/
> > IceGlobalContext.cpp#newcode34
> > src/IceGlobalContext.cpp:34: cl::init(1));
> > Can you default initialize to time(0) or something like that?
> >
> > https://codereview.chromium.org/455593004/diff/1/src/IceGlobalContext.h
> > File src/IceGlobalContext.h (right):
> >
> > https://codereview.chromium.org/455593004/diff/1/src/
> > IceGlobalContext.h#newcode25
> > src/IceGlobalContext.h:25: #include "IceRNG.h"
> > alphabetize includes
> >
> > https://codereview.chromium.org/455593004/diff/1/src/
> > IceGlobalContext.h#newcode95
> > src/IceGlobalContext.h:95: RandomNumberGenerator &getRNG() { return RNG;
> > }
> > Please add TODOs in appropriate places:
> >
> > 1. Switch to RNG implementation from LLVM or C++11.
> >
> > 2. Make the RNG play nicely with multithreaded translation.
> >
> > 3. Make it possible to replay the RNG sequence in a subsequent run, for
> > reproducing a bug.  Print the seed/whatever in a comment in the asm
> > output.  Embed the seed in the binary via metadata that an attacker
> > can't introspect.
> >
> > https://codereview.chromium.org/455593004/
> >
> >
> > --
> > You received this message because you are subscribed to the Google Groups
> > "Native-Client-Reviews" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> > email to mailto:native-client-reviews+unsubscribe@googlegroups.com.
> > To post to this group, send email to native-client-reviews@
> > http://googlegroups.com.
> > Visit this group at http://groups.google.com/group/native-client-reviews.
> > For more options, visit https://groups.google.com/d/optout.
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Native-Client-Reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:native-client-reviews+unsubscribe@googlegroups.com.
> To post to this group, send email to
mailto:native-client-reviews@googlegroups.com.
> Visit this group at http://groups.google.com/group/native-client-reviews.
> For more options, visit https://groups.google.com/d/optout.

[wala, 2014-08-08 21:02:13]

Committed patchset #3 manually as 1bd2fce (presubmit successful).