Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Unified Diff: chrome/browser/autocomplete/search_provider_unittest.cc

Issue 455563002: Prefetch cache pt1 - MRU (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pfq-base
Patch Set: Review fixes. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/search_provider_unittest.cc
diff --git a/chrome/browser/autocomplete/search_provider_unittest.cc b/chrome/browser/autocomplete/search_provider_unittest.cc
index 1d6977e2ea90684fc663163d9c9abe9f0f3b0a80..7c9be34a9239b3769e0ce0a6b5b1bcdb5077a953 100644
--- a/chrome/browser/autocomplete/search_provider_unittest.cc
+++ b/chrome/browser/autocomplete/search_provider_unittest.cc
@@ -3230,9 +3230,6 @@ TEST_F(SearchProviderTest, SessionToken) {
}
TEST_F(SearchProviderTest, AnswersCache) {
- // Initial condition: empty cache.
- ASSERT_TRUE(provider_->last_answer_seen_.full_query_text.empty());
-
AutocompleteResult result;
ACMatches matches;
AutocompleteMatch match1;
@@ -3248,10 +3245,7 @@ TEST_F(SearchProviderTest, AnswersCache) {
matches.push_back(non_answer_match1);
result.AppendMatches(matches);
provider_->RegisterDisplayedAnswers(result);
- EXPECT_EQ(base::ASCIIToUTF16("weather los angeles"),
- provider_->last_answer_seen_.full_query_text);
- EXPECT_EQ(base::ASCIIToUTF16("2334"),
- provider_->last_answer_seen_.query_type);
+ ASSERT_FALSE(provider_->answers_cache_.empty());
// Test that DoAnswersQuery retrieves data from cache.
AutocompleteInput input(base::ASCIIToUTF16("weather l"),
@@ -3263,14 +3257,4 @@ TEST_F(SearchProviderTest, AnswersCache) {
EXPECT_EQ(base::ASCIIToUTF16("weather los angeles"),
provider_->prefetch_data_.full_query_text);
EXPECT_EQ(base::ASCIIToUTF16("2334"), provider_->prefetch_data_.query_type);
-
- // Mismatching input will return empty prefetch data.
- AutocompleteInput input2(base::ASCIIToUTF16("weather n"),
- base::string16::npos, base::string16(), GURL(),
- metrics::OmniboxEventProto::INVALID_SPEC, false,
- false, true, true,
- ChromeAutocompleteSchemeClassifier(&profile_));
- provider_->DoAnswersQuery(input2);
- EXPECT_TRUE(provider_->prefetch_data_.full_query_text.empty());
- EXPECT_TRUE(provider_->prefetch_data_.query_type.empty());
}

Powered by Google App Engine
This is Rietveld 408576698