Prefetch cache pt1 - MRU

[AiS] Better prefetch cache.

Step 1 - factor out current cache and increase its size.

BUG=401758
R=pkasting@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291307

[groby-ooo-7-16, 2014-08-08 21:51:45]

Step one of making prefetch cache persistent.

[groby-ooo-7-16, 2014-08-11 19:38:21]

Friendly ping? (Sorry if "step 1" was misleading. I plan to land this, if
possible, and do further steps in separate CLs)

[Peter Kasting, 2014-08-11 22:15:34]

https://codereview.chromium.org/455563002/diff/40001/chrome/browser/autocompl...
File chrome/browser/autocomplete/answers_cache.cc (right):

https://codereview.chromium.org/455563002/diff/40001/chrome/browser/autocompl...
chrome/browser/autocomplete/answers_cache.cc:54: return cache_.empty();
Nit: This should perhaps be inlined into the header and the function renamed
is_empty() (or empty() -- I'm personally a fan of matching the STL names)

https://codereview.chromium.org/455563002/diff/40001/chrome/browser/autocompl...
File chrome/browser/autocomplete/answers_cache.h (right):

https://codereview.chromium.org/455563002/diff/40001/chrome/browser/autocompl...
chrome/browser/autocomplete/answers_cache.h:21: // Cache for the most-recently
seen answer for AiS.
Nit: Probably should spell out "AiS"

https://codereview.chromium.org/455563002/diff/40001/chrome/browser/autocompl...
chrome/browser/autocomplete/answers_cache.h:27: // Get the top answer query
completion for the query term. The query data
Nit: Get -> Gets (and similar below)

https://codereview.chromium.org/455563002/diff/40001/chrome/browser/autocompl...
chrome/browser/autocomplete/answers_cache.h:35: bool IsEmpty();  // Signal if
cache is empty.
Nit: Put the comment above the function.

https://codereview.chromium.org/455563002/diff/40001/chrome/browser/autocompl...
chrome/browser/autocomplete/answers_cache.h:39: typedef
std::list<AnswersQueryData> Cache;
Did you consider a priority_queue (or queue or deque) for this?  I'm not
convinced they'd actually be better, I was just wondering whether something like
a priority_queue (sorting based on timestamps, I guess?) would lead to any less
code in terms of keeping the list sorted properly.

It seems like using a list is pretty efficient, though... maybe it doesn't
really matter much.

https://codereview.chromium.org/455563002/diff/40001/chrome/browser/autocompl...
File chrome/browser/autocomplete/answers_cache_unittest.cc (right):

https://codereview.chromium.org/455563002/diff/40001/chrome/browser/autocompl...
chrome/browser/autocomplete/answers_cache_unittest.cc:34: // Mismatched prefix
retrievs empty data.
Nit: retrieves

https://codereview.chromium.org/455563002/diff/40001/chrome/browser/autocompl...
File chrome/browser/autocomplete/search_provider.cc (right):

https://codereview.chromium.org/455563002/diff/40001/chrome/browser/autocompl...
chrome/browser/autocomplete/search_provider.cc:1245: prefetch_data_ =
answers_cache_.GetTopAnswerEntry(input.text());
Should this just be inlined into the caller?  Or are you going to make this more
complex in the next step?

https://codereview.chromium.org/455563002/diff/40001/chrome/browser/autocompl...
File chrome/browser/autocomplete/search_provider_unittest.cc (left):

https://codereview.chromium.org/455563002/diff/40001/chrome/browser/autocompl...
chrome/browser/autocomplete/search_provider_unittest.cc:3267: // Mismatching
input will return empty prefetch data.
I realize you mainly moved this test into the other unittest file, but is there
any part of it that should still be here, to test any other plumbing in
SearchProvider?

[groby-ooo-7-16, 2014-08-12 01:16:27]

PTAL

https://codereview.chromium.org/455563002/diff/40001/chrome/browser/autocompl...
File chrome/browser/autocomplete/answers_cache.cc (right):

https://codereview.chromium.org/455563002/diff/40001/chrome/browser/autocompl...
chrome/browser/autocomplete/answers_cache.cc:54: return cache_.empty();
On 2014/08/11 22:15:33, Peter Kasting wrote:
> Nit: This should perhaps be inlined into the header and the function renamed
> is_empty() (or empty() -- I'm personally a fan of matching the STL names)

Done.

https://codereview.chromium.org/455563002/diff/40001/chrome/browser/autocompl...
File chrome/browser/autocomplete/answers_cache.h (right):

https://codereview.chromium.org/455563002/diff/40001/chrome/browser/autocompl...
chrome/browser/autocomplete/answers_cache.h:21: // Cache for the most-recently
seen answer for AiS.
On 2014/08/11 22:15:33, Peter Kasting wrote:
> Nit: Probably should spell out "AiS"

Done.

https://codereview.chromium.org/455563002/diff/40001/chrome/browser/autocompl...
chrome/browser/autocomplete/answers_cache.h:27: // Get the top answer query
completion for the query term. The query data
On 2014/08/11 22:15:33, Peter Kasting wrote:
> Nit: Get -> Gets (and similar below)

Done.

https://codereview.chromium.org/455563002/diff/40001/chrome/browser/autocompl...
chrome/browser/autocomplete/answers_cache.h:35: bool IsEmpty();  // Signal if
cache is empty.
On 2014/08/11 22:15:33, Peter Kasting wrote:
> Nit: Put the comment above the function.

Done.

https://codereview.chromium.org/455563002/diff/40001/chrome/browser/autocompl...
chrome/browser/autocomplete/answers_cache.h:39: typedef
std::list<AnswersQueryData> Cache;
I've considered a queue/priority_queue, yes. But 

a) queue/priority_queue has no iterators.
b) The only time ordering changes is during insert/get, when I already have the
element available to re-place in a different spot
c) It rises the annoying issue of strictly monotonic timestamps. (Esp. for
testing)

dequeue has O(n) behavior for removal. (Not that it'll matter horribly much :)

So list seemed the best fit.

On 2014/08/11 22:15:33, Peter Kasting wrote:
> Did you consider a priority_queue (or queue or deque) for this?  I'm not
> convinced they'd actually be better, I was just wondering whether something
like
> a priority_queue (sorting based on timestamps, I guess?) would lead to any
less
> code in terms of keeping the list sorted properly.
> 
> It seems like using a list is pretty efficient, though... maybe it doesn't
> really matter much.

https://codereview.chromium.org/455563002/diff/40001/chrome/browser/autocompl...
File chrome/browser/autocomplete/answers_cache_unittest.cc (right):

https://codereview.chromium.org/455563002/diff/40001/chrome/browser/autocompl...
chrome/browser/autocomplete/answers_cache_unittest.cc:34: // Mismatched prefix
retrievs empty data.
On 2014/08/11 22:15:33, Peter Kasting wrote:
> Nit: retrieves

Done.

https://codereview.chromium.org/455563002/diff/40001/chrome/browser/autocompl...
File chrome/browser/autocomplete/search_provider.cc (right):

https://codereview.chromium.org/455563002/diff/40001/chrome/browser/autocompl...
chrome/browser/autocomplete/search_provider.cc:1245: prefetch_data_ =
answers_cache_.GetTopAnswerEntry(input.text());
On 2014/08/11 22:15:33, Peter Kasting wrote:
> Should this just be inlined into the caller?  Or are you going to make this
more
> complex in the next step?

This is mostly so I can test that DoAnswersQuery actually fetches data from the
cache.

There's significantly more setup to test that behavior if it moves into
SearchProvider::Start.

https://codereview.chromium.org/455563002/diff/40001/chrome/browser/autocompl...
File chrome/browser/autocomplete/search_provider_unittest.cc (left):

https://codereview.chromium.org/455563002/diff/40001/chrome/browser/autocompl...
chrome/browser/autocomplete/search_provider_unittest.cc:3267: // Mismatching
input will return empty prefetch data.
On 2014/08/11 22:15:34, Peter Kasting wrote:
> I realize you mainly moved this test into the other unittest file, but is
there
> any part of it that should still be here, to test any other plumbing in
> SearchProvider?

This used to test the second branch of the ternary in DoAnswersQuery - at this
point, it'd only test that assigning an empty string results in an empty string
:)

So, no, I don't think this covers any logic.

[groby-ooo-7-16, 2014-08-12 03:43:02]

Now with actual CL

[Peter Kasting, 2014-08-12 18:32:13]

LGTM

https://codereview.chromium.org/455563002/diff/60001/chrome/browser/autocompl...
File chrome/browser/autocomplete/answers_cache.h (right):

https://codereview.chromium.org/455563002/diff/60001/chrome/browser/autocompl...
chrome/browser/autocomplete/answers_cache.h:36: bool empty() { return
cache_.empty(); }
Nit: Can be const

[groby-ooo-7-16, 2014-08-12 19:53:33]

https://codereview.chromium.org/455563002/diff/60001/chrome/browser/autocompl...
File chrome/browser/autocomplete/answers_cache.h (right):

https://codereview.chromium.org/455563002/diff/60001/chrome/browser/autocompl...
chrome/browser/autocomplete/answers_cache.h:36: bool empty() { return
cache_.empty(); }
On 2014/08/12 18:32:13, Peter Kasting wrote:
> Nit: Can be const

Done.

[groby-ooo-7-16, 2014-08-12 19:53:36]

The CQ bit was checked by groby@chromium.org

[commit-bot: I haz the power, 2014-08-12 19:58:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/groby@chromium.org/455563002/80001

[commit-bot: I haz the power, 2014-08-12 21:06:33]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/40715)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/45949)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg/bui...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-12 21:12:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-12 21:12:59]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/40750)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/45978)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg/bui...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)

[groby-ooo-7-16, 2014-08-15 03:56:38]

The CQ bit was checked by groby@chromium.org

[commit-bot: I haz the power, 2014-08-15 03:57:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/groby@chromium.org/455563002/100001

[commit-bot: I haz the power, 2014-08-15 04:11:28]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/42122)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/47333)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg/bui...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-15 04:16:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-15 04:16:25]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/42124)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/47335)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg/bui...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[groby-ooo-7-16, 2014-08-15 05:17:59]

The CQ bit was checked by groby@chromium.org

[commit-bot: I haz the power, 2014-08-15 05:22:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/groby@chromium.org/455563002/120001

[commit-bot: I haz the power, 2014-08-15 08:48:07]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/42185)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg/bui...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[commit-bot: I haz the power, 2014-08-15 08:57:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-15 08:57:04]

Try jobs failed on following builders:
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg/bui...)

[groby-ooo-7-16, 2014-08-22 00:01:57]

The CQ bit was checked by groby@chromium.org

[commit-bot: I haz the power, 2014-08-22 00:04:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/groby@chromium.org/455563002/140001

[commit-bot: I haz the power, 2014-08-22 01:00:28]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[commit-bot: I haz the power, 2014-08-22 01:43:14]

Committed patchset #8 (140001) as 291307