Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Unified Diff: tools/metrics/actions/actions.xml

Issue 455543003: Add MobileUsingMenuBy* metric actions owner and remove an unused one. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/metrics/actions/actions.xml
diff --git a/tools/metrics/actions/actions.xml b/tools/metrics/actions/actions.xml
index 0560f48e6b3b977f8429195de5808fecc2b3e336..3523bfb55c741b8395d51edf937aeaf6c0544297 100644
--- a/tools/metrics/actions/actions.xml
+++ b/tools/metrics/actions/actions.xml
@@ -7538,24 +7538,25 @@ should be able to be added at any place in this file.
<description>Please enter the description of this user action.</description>
</action>
-<action name="MobileUsingMenuByHwButtonDragging">
Alexei Svitkine (slow) 2014/08/08 15:20:49 Please keep this action since we have samples on i
Kibeom Kim (inactive) 2014/08/08 18:29:15 I removed HW menu dragging recently, https://coder
Alexei Svitkine (slow) 2014/08/08 18:31:44 Yes, please.
Kibeom Kim (inactive) 2014/08/08 18:44:06 Done.
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
- <description>Please enter the description of this user action.</description>
-</action>
-
<action name="MobileUsingMenuByHwButtonTap">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
- <description>Please enter the description of this user action.</description>
+ <owner>kkimlabs@chromium.org</owner>
+ <description>
+ Only for Android. Menu is shown by tapping hardware menu button.
+ </description>
</action>
<action name="MobileUsingMenuBySwButtonDragging">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
- <description>Please enter the description of this user action.</description>
+ <owner>kkimlabs@chromium.org</owner>
+ <description>
+ Only for Android. Menu is shown by dragging from software menu button.
+ </description>
</action>
<action name="MobileUsingMenuBySwButtonTap">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
- <description>Please enter the description of this user action.</description>
+ <owner>kkimlabs@chromium.org</owner>
+ <description>
+ Only for Android. Menu is shown by tapping software menu button.
+ </description>
</action>
<action name="MostVisited0">

Powered by Google App Engine
This is Rietveld 408576698