Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 455533002: Reduce DBus ObjectUnknown ERROR to WARNING (Closed)

Created:
6 years, 4 months ago by stevenjb
Modified:
6 years, 4 months ago
Reviewers:
hashimoto, satorux1
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Reduce DBus ObjectUnknown ERROR to WARNING BUG=401571 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288446

Patch Set 1 #

Total comments: 3

Patch Set 2 : Correctly log at severity #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M dbus/object_proxy.h View 1 chunk +2 lines, -1 line 0 comments Download
M dbus/object_proxy.cc View 1 2 chunks +14 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
stevenjb
6 years, 4 months ago (2014-08-07 22:32:48 UTC) #1
hashimoto
https://codereview.chromium.org/455533002/diff/1/dbus/object_proxy.cc File dbus/object_proxy.cc (right): https://codereview.chromium.org/455533002/diff/1/dbus/object_proxy.cc#newcode573 dbus/object_proxy.cc:573: severity = logging::LOG_WARNING; This variable looks unused and it ...
6 years, 4 months ago (2014-08-08 02:46:31 UTC) #2
hashimoto
https://codereview.chromium.org/455533002/diff/1/dbus/object_proxy.cc File dbus/object_proxy.cc (right): https://codereview.chromium.org/455533002/diff/1/dbus/object_proxy.cc#newcode573 dbus/object_proxy.cc:573: severity = logging::LOG_WARNING; On 2014/08/08 02:46:31, hashimoto wrote: > ...
6 years, 4 months ago (2014-08-08 07:28:46 UTC) #3
stevenjb
ptal https://codereview.chromium.org/455533002/diff/1/dbus/object_proxy.cc File dbus/object_proxy.cc (right): https://codereview.chromium.org/455533002/diff/1/dbus/object_proxy.cc#newcode573 dbus/object_proxy.cc:573: severity = logging::LOG_WARNING; On 2014/08/08 07:28:46, hashimoto wrote: ...
6 years, 4 months ago (2014-08-08 16:31:58 UTC) #4
hashimoto
lgtm
6 years, 4 months ago (2014-08-08 17:17:42 UTC) #5
stevenjb
The CQ bit was checked by stevenjb@chromium.org
6 years, 4 months ago (2014-08-08 17:21:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/455533002/20001
6 years, 4 months ago (2014-08-08 17:22:14 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-08 21:40:59 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 21:57:23 UTC) #9
Message was sent while issue was closed.
Change committed as 288446

Powered by Google App Engine
This is Rietveld 408576698