Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(892)

Issue 455503002: Expanded suppression for conformance/extensions/angle-instanced-arrays.html. (Closed)

Created:
6 years, 4 months ago by Ken Russell (switch to Gerrit)
Modified:
6 years, 4 months ago
Reviewers:
Zhenyao Mo, oetuaho-nv
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, oetuaho-nv
Project:
chromium
Visibility:
Public.

Description

Expanded suppression for conformance/extensions/angle-instanced-arrays.html. BUG=398337, 401716 NOTRY=true TBR=zmo@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288276

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M content/test/gpu/gpu_tests/webgl_conformance_expectations.py View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ken Russell (switch to Gerrit)
Tested locally.
6 years, 4 months ago (2014-08-07 22:18:38 UTC) #1
Ken Russell (switch to Gerrit)
The CQ bit was checked by kbr@chromium.org
6 years, 4 months ago (2014-08-07 22:18:40 UTC) #2
Zhenyao Mo
LGTM
6 years, 4 months ago (2014-08-07 22:27:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kbr@chromium.org/455503002/1
6 years, 4 months ago (2014-08-07 23:00:31 UTC) #4
commit-bot: I haz the power
Change committed as 288276
6 years, 4 months ago (2014-08-08 09:20:12 UTC) #5
oetuaho-nv
6 years, 4 months ago (2014-08-08 11:38:50 UTC) #6
Message was sent while issue was closed.
Thanks for taking care of this, it was getting late in Finland by the time that
the WebGL roll was merged.

A simple workaround could be to always call the instanced draw functions if
they're available, though the perf impact would need to be evaluated across
platforms.

Powered by Google App Engine
This is Rietveld 408576698