Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1311)

Issue 455453002: Remove WebMediaPlayerClient::preload() and volume() (Closed)

Created:
6 years, 4 months ago by philipj_slow
Modified:
6 years, 4 months ago
CC:
abarth-chromium, blink-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, jamesr, philipj_slow
Project:
blink
Visibility:
Public.

Description

Remove WebMediaPlayerClient::preload() and volume() They are unused as of Chromium r288080. The WebMediaPlayerClientImpl::m_preload member became unused, so remove it. This makes WebMediaPlayerClientImpl::setPreload look fragile, and it's possible that there are existing bugs where the preload state is not propagated correctly. However, HTMLMediaElement should eventually call WebMediaPlayer::setPreload() directly, so the removed code will be of no use. BUG=401415 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179773

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
M Source/web/WebMediaPlayerClientImpl.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/web/WebMediaPlayerClientImpl.cpp View 3 chunks +0 lines, -13 lines 0 comments Download
M public/platform/WebMediaPlayerClient.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
philipj_slow
PTAL
6 years, 4 months ago (2014-08-07 20:43:35 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm \o/
6 years, 4 months ago (2014-08-07 23:19:46 UTC) #2
abarth-chromium
lgtm
6 years, 4 months ago (2014-08-07 23:40:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/455453002/1
6 years, 4 months ago (2014-08-07 23:49:52 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 00:58:30 UTC) #5
Message was sent while issue was closed.
Change committed as 179773

Powered by Google App Engine
This is Rietveld 408576698