Issue 455453002: Remove WebMediaPlayerClient::preload() and volume()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 455453002: Remove WebMediaPlayerClient::preload() and volume() (Closed)

Created:
6 years, 4 months ago by philipj_slow

Modified:
6 years, 4 months ago

Reviewers:
acolwell GONE FROM CHROMIUM, abarth-chromium

CC:
abarth-chromium, blink-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, jamesr, philipj_slow

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Remove WebMediaPlayerClient::preload() and volume() They are unused as of Chromium r288080. The WebMediaPlayerClientImpl::m_preload member became unused, so remove it. This makes WebMediaPlayerClientImpl::setPreload look fragile, and it's possible that there are existing bugs where the preload state is not propagated correctly. However, HTMLMediaElement should eventually call WebMediaPlayer::setPreload() directly, so the removed code will be of no use. BUG=401415 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179773

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -19 lines)			Patch
M	Source/web/WebMediaPlayerClientImpl.h	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	Source/web/WebMediaPlayerClientImpl.cpp	View	3 chunks	+0 lines, -13 lines	0 comments	Download
M	public/platform/WebMediaPlayerClient.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/455453002/1

6 years, 4 months ago (2014-08-07 23:49:52 UTC) #4

Message was sent while issue was closed.

Change committed as 179773

Expand Messages | Collapse Messages