Remember the configured device scale factor for external displays.

Remember the configured device scale factor for external displays.

Users can specify the device scale factor for some external
displays. Now, it remembers the configured device scale factor
to the local storage, and recovers to the specified value when
reconnected.

This also fixes the bug when the user specifies the resolution
and the device scale factor at the same time (DSF was ignored
beforehand).

BUG=396704
R=oshima@chromium.org
TEST=manually, unit_tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288412

[oshima, 2014-08-07 23:03:49]

https://codereview.chromium.org/455443002/diff/1/ash/display/display_change_o...
File ash/display/display_change_observer_chromeos.cc (right):

https://codereview.chromium.org/455443002/diff/1/ash/display/display_change_o...
ash/display/display_change_observer_chromeos.cc:195: if
(!ui::IsDisplaySizeBlackListed(state.display->physical_size())) {
internal display should not be black listed, so we can remove this.

https://codereview.chromium.org/455443002/diff/1/ash/display/display_info.cc
File ash/display/display_info.cc (right):

https://codereview.chromium.org/455443002/diff/1/ash/display/display_info.cc#...
ash/display/display_info.cc:131: if (sscanf(main_spec.c_str(), "%dx%d*%f",
can you consolidate this?

[Jun Mukai, 2014-08-08 00:57:34]

https://codereview.chromium.org/455443002/diff/1/ash/display/display_change_o...
File ash/display/display_change_observer_chromeos.cc (right):

https://codereview.chromium.org/455443002/diff/1/ash/display/display_change_o...
ash/display/display_change_observer_chromeos.cc:195: if
(!ui::IsDisplaySizeBlackListed(state.display->physical_size())) {
On 2014/08/07 23:03:49, oshima wrote:
> internal display should not be black listed, so we can remove this.

Done.

https://codereview.chromium.org/455443002/diff/1/ash/display/display_info.cc
File ash/display/display_info.cc (right):

https://codereview.chromium.org/455443002/diff/1/ash/display/display_info.cc#...
ash/display/display_info.cc:131: if (sscanf(main_spec.c_str(), "%dx%d*%f",
On 2014/08/07 23:03:49, oshima wrote:
> can you consolidate this?

Done.

[oshima, 2014-08-08 16:21:00]

lgtm with a nit

https://codereview.chromium.org/455443002/diff/20001/ash/display/display_mana...
File ash/display/display_manager.cc (right):

https://codereview.chromium.org/455443002/diff/20001/ash/display/display_mana...
ash/display/display_manager.cc:547: if (!resolution_in_pixels.IsEmpty()) {
Can you add DCHECK to make sure display_id is not internal in this case?

[Jun Mukai, 2014-08-08 16:23:58]

https://codereview.chromium.org/455443002/diff/20001/ash/display/display_mana...
File ash/display/display_manager.cc (right):

https://codereview.chromium.org/455443002/diff/20001/ash/display/display_mana...
ash/display/display_manager.cc:547: if (!resolution_in_pixels.IsEmpty()) {
On 2014/08/08 16:21:00, oshima wrote:
> Can you add DCHECK to make sure display_id is not internal in this case?

Done.

[Jun Mukai, 2014-08-08 16:24:09]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-08-08 16:24:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mukai@chromium.org/455443002/40001

[commit-bot: I haz the power, 2014-08-08 19:23:36]

Change committed as 288412