Oilpan: fix tracing of un-initialized part objects during conservative GCs.

Source/platform/heap/Visitor.h

Index: Source/platform/heap/Visitor.h
diff --git a/Source/platform/heap/Visitor.h b/Source/platform/heap/Visitor.h
index 7a701fc38f7ad9416b1c05669ead56532ea3fc4c..1030e263ba2fa0f3852bc1a8e48e02500bd6518f 100644
--- a/Source/platform/heap/Visitor.h
+++ b/Source/platform/heap/Visitor.h
@@ -289,6 +289,11 @@ public:
     template<typename T>
     void trace(const T& t)
     {
+        if (WTF::IsPolymorphic<T>::value) {
+            intptr_t vtable = *reinterpret_cast<const intptr_t*>(&t);
+            if (!vtable)

[haraken, 2014/08/11 10:44:02]

Can we merge this check with vTableInitialized() in Heap.cpp?

(I thought that the vTableInitialized() check in
HeapPage<Header>::checkAndMarkPointer was enough.)

[Mads Ager (chromium), 2014/08/11 12:17:36]

These are two different checks:

The check that we already have is for the case where an argument to a
constructor allocates. In that case we can see a pointer on the stack that
points to a garbage collected object that should have a virtual table but it has
not yet been initialized.

The check that I'm adding here is for part objects that have virtual methods but
where the vtable is not yet initialized because the construction of the part
object hasn't started yet.

We are performing conservative scanning of the object reachable from the stack.
We shouldn't have to (when Ian has updated the plugin to make sure that the
first word is actually a vtable). I'll remove the conservative scanning on the
stack so that we just ignore the object in both cases (and maybe add asserts
that the object pointed to on the stack is completely uninitialized).

+                return;
+        }
         const_cast<T&>(t).trace(this);
     }