Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 455333002: ViewportChangeListener deregister and reregister on DOM changes. (Closed)

Created:
6 years, 4 months ago by Yoav Weiss
Modified:
6 years, 4 months ago
Reviewers:
Mike West
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

ViewportChangeListener deregister and reregister on DOM changes. BUG=402263, 402218 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179937

Patch Set 1 #

Patch Set 2 : Added a test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, --1 lines) Patch
A LayoutTests/fast/dom/HTMLImageElement/image-srcset-deregistration-after-move.html View 1 1 chunk +23 lines, -0 lines 0 comments Download
A + LayoutTests/fast/dom/HTMLImageElement/image-srcset-deregistration-after-move-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/html/HTMLImageElement.cpp View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Yoav Weiss
6 years, 4 months ago (2014-08-11 09:57:32 UTC) #1
Mike West
Looks reasonable. As I mentioned, I'm interested in the perf impact of doing this work ...
6 years, 4 months ago (2014-08-11 10:05:05 UTC) #2
Yoav Weiss
On 2014/08/11 10:05:05, Mike West wrote: > Looks reasonable. As I mentioned, I'm interested in ...
6 years, 4 months ago (2014-08-11 10:10:44 UTC) #3
Yoav Weiss
The CQ bit was checked by yoav@yoav.ws
6 years, 4 months ago (2014-08-11 10:10:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoav@yoav.ws/455333002/20001
6 years, 4 months ago (2014-08-11 10:11:03 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-11 11:27:16 UTC) #6
Message was sent while issue was closed.
Change committed as 179937

Powered by Google App Engine
This is Rietveld 408576698