Issue 455323003: Add DisplayType to app list SearchResults

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 455323003: Add DisplayType to app list SearchResults (Closed)

Created:
6 years, 4 months ago by calamity

Modified:
6 years, 4 months ago

Reviewers:
Matt Giuca

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add DisplayType to app list SearchResults This CL adds a DisplayType property to app list SearchResult properties which will be used to determine where the results should be displayed in the experimental app list. BUG=349727 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288976

Patch Set 1 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -2 lines)			Patch
M	chrome/browser/ui/app_list/search/app_result.cc	View	3 chunks	+5 lines, -1 line	0 comments	Download
M	ui/app_list/search_result.h	View	4 chunks	+11 lines, -0 lines	0 comments	Download
M	ui/app_list/search_result.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/455323003/60001

6 years, 4 months ago (2014-08-12 04:07:05 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium.win ...

6 years, 4 months ago (2014-08-12 05:59:12 UTC) #5

Message was sent while issue was closed.

Change committed as 288976

Expand Messages | Collapse Messages