Source/core/streams/UnderlyingSource.h - Issue 455303002: Add 'stream' to XMLHttpRequest response type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/streams/UnderlyingSource.h

Issue 455303002: Add 'stream' to XMLHttpRequest response type. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@stream-promise-property-reset

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/http/tests/xmlhttprequest/response-stream.html ('K') | « Source/core/streams/ReadableStreamTest.cpp ('k') | Source/core/xml/XMLHttpRequest.h » ('j') | Source/core/xml/XMLHttpRequest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/streams/UnderlyingSource.h

diff --git a/Source/core/streams/UnderlyingSource.h b/Source/core/streams/UnderlyingSource.h

index f74117570b171d1eeffcc324685daf46179eb6a7..3f025e4e6466b8b90fa13e391eb32754f597a5ee 100644

--- a/Source/core/streams/UnderlyingSource.h

+++ b/Source/core/streams/UnderlyingSource.h

@@ -5,6 +5,7 @@

#ifndef UnderlyingSource_h

#define UnderlyingSource_h

+#include "bindings/core/v8/ScriptPromise.h"

#include "bindings/core/v8/ScriptValue.h"

#include "platform/heap/Heap.h"

@@ -13,13 +14,10 @@ namespace blink {

class ExceptionState;

class ScriptState;

-class UnderlyingSource : public GarbageCollectedFinalized<UnderlyingSource> {

+class UnderlyingSource : public GarbageCollectedMixin {

public:

virtual ~UnderlyingSource() { }

- // When startSource fails asynchronously, it must call

- // ReadableStream::error with a DOM exception.

- virtual ScriptPromise startSource(ExceptionState*) = 0;

virtual void pullSource() = 0;

virtual ScriptPromise cancelSource(ScriptState*, ScriptValue reason) = 0;

virtual void trace(Visitor*) { }