Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 455303002: Add 'stream' to XMLHttpRequest response type. (Closed)

Created:
6 years, 4 months ago by yhirano
Modified:
6 years, 4 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, Inactive, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@stream-promise-property-reset
Project:
blink
Visibility:
Public.

Description

Add 'stream' to XMLHttpRequest response type. Make XMLHttpRequest return a ReadableStream when the response type is set to 'stream'. This CL also modifies ReadableStream interface and implementation to make it enable for XMLHttpRequest to use ReadableStream functionalities. BUG=401396 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180432

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Total comments: 11

Patch Set 7 : rebase #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Total comments: 14

Patch Set 11 : rebase #

Patch Set 12 : #

Patch Set 13 : #

Total comments: 2

Patch Set 14 : #

Patch Set 15 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+354 lines, -145 lines) Patch
A LayoutTests/http/tests/xmlhttprequest/response-stream.html View 1 2 3 4 5 6 7 8 9 1 chunk +94 lines, -0 lines 0 comments Download
A + LayoutTests/http/tests/xmlhttprequest/response-stream-abort.html View 1 2 3 4 chunks +22 lines, -13 lines 0 comments Download
A LayoutTests/http/tests/xmlhttprequest/response-stream-cancel.html View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +66 lines, -0 lines 0 comments Download
M Source/bindings/core/v8/custom/V8XMLHttpRequestCustom.cpp View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +10 lines, -1 line 0 comments Download
M Source/core/streams/ReadableStream.h View 3 chunks +10 lines, -6 lines 0 comments Download
M Source/core/streams/ReadableStream.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 3 chunks +25 lines, -29 lines 0 comments Download
M Source/core/streams/ReadableStream.idl View 1 chunk +14 lines, -0 lines 0 comments Download
M Source/core/streams/ReadableStreamImpl.h View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/streams/ReadableStreamTest.cpp View 1 2 3 4 5 14 chunks +19 lines, -74 lines 0 comments Download
M Source/core/streams/UnderlyingSource.h View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/xml/XMLHttpRequest.h View 1 2 3 4 5 6 5 chunks +9 lines, -3 lines 0 comments Download
M Source/core/xml/XMLHttpRequest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 11 chunks +75 lines, -8 lines 0 comments Download
M Source/core/xml/XMLHttpRequest.idl View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 18 (0 generated)
yhirano
This CL depends on https://codereview.chromium.org/456233002/ .
6 years, 4 months ago (2014-08-11 08:02:21 UTC) #1
tyoshino (SeeGerritForStatus)
https://codereview.chromium.org/455303002/diff/100001/Source/core/xml/XMLHttpRequest.cpp File Source/core/xml/XMLHttpRequest.cpp (right): https://codereview.chromium.org/455303002/diff/100001/Source/core/xml/XMLHttpRequest.cpp#newcode337 Source/core/xml/XMLHttpRequest.cpp:337: return nullptr; i heard that we're still using 0 ...
6 years, 4 months ago (2014-08-14 00:38:56 UTC) #2
tyoshino (SeeGerritForStatus)
https://codereview.chromium.org/455303002/diff/100001/LayoutTests/http/tests/xmlhttprequest/response-stream.html File LayoutTests/http/tests/xmlhttprequest/response-stream.html (right): https://codereview.chromium.org/455303002/diff/100001/LayoutTests/http/tests/xmlhttprequest/response-stream.html#newcode3 LayoutTests/http/tests/xmlhttprequest/response-stream.html:3: <body> feel free to omit <html> and <body> https://codereview.chromium.org/455303002/diff/100001/LayoutTests/http/tests/xmlhttprequest/response-stream.html#newcode30 ...
6 years, 4 months ago (2014-08-14 04:39:10 UTC) #3
yhirano
https://codereview.chromium.org/455303002/diff/100001/LayoutTests/http/tests/xmlhttprequest/response-stream.html File LayoutTests/http/tests/xmlhttprequest/response-stream.html (right): https://codereview.chromium.org/455303002/diff/100001/LayoutTests/http/tests/xmlhttprequest/response-stream.html#newcode3 LayoutTests/http/tests/xmlhttprequest/response-stream.html:3: <body> On 2014/08/14 04:39:09, tyoshino wrote: > feel free ...
6 years, 4 months ago (2014-08-14 06:48:54 UTC) #4
yhirano
https://codereview.chromium.org/455303002/diff/100001/LayoutTests/http/tests/xmlhttprequest/response-stream.html File LayoutTests/http/tests/xmlhttprequest/response-stream.html (right): https://codereview.chromium.org/455303002/diff/100001/LayoutTests/http/tests/xmlhttprequest/response-stream.html#newcode30 LayoutTests/http/tests/xmlhttprequest/response-stream.html:30: rec(resolve, reject); > I'd leave the first stream.wait to ...
6 years, 4 months ago (2014-08-14 06:49:39 UTC) #5
tyoshino (SeeGerritForStatus)
https://codereview.chromium.org/455303002/diff/180001/LayoutTests/http/tests/xmlhttprequest/response-stream-abort.html File LayoutTests/http/tests/xmlhttprequest/response-stream-abort.html (right): https://codereview.chromium.org/455303002/diff/180001/LayoutTests/http/tests/xmlhttprequest/response-stream-abort.html#newcode40 LayoutTests/http/tests/xmlhttprequest/response-stream-abort.html:40: assert_equals(xhr.readyState, xhr.UNSENT, 'xhr.readyState after abort() call'); oh, why we ...
6 years, 4 months ago (2014-08-15 09:32:06 UTC) #6
yhirano
https://codereview.chromium.org/455303002/diff/180001/LayoutTests/http/tests/xmlhttprequest/response-stream-abort.html File LayoutTests/http/tests/xmlhttprequest/response-stream-abort.html (right): https://codereview.chromium.org/455303002/diff/180001/LayoutTests/http/tests/xmlhttprequest/response-stream-abort.html#newcode40 LayoutTests/http/tests/xmlhttprequest/response-stream-abort.html:40: assert_equals(xhr.readyState, xhr.UNSENT, 'xhr.readyState after abort() call'); On 2014/08/15 09:32:06, ...
6 years, 4 months ago (2014-08-15 09:51:35 UTC) #7
tyoshino (SeeGerritForStatus)
lgtm
6 years, 4 months ago (2014-08-18 04:30:48 UTC) #8
yhirano
+tkent for OWNER review.
6 years, 4 months ago (2014-08-18 04:46:17 UTC) #9
haraken
bindings/ LGTM.
6 years, 4 months ago (2014-08-18 04:47:10 UTC) #10
tkent
rslgtm https://codereview.chromium.org/455303002/diff/240001/Source/core/xml/XMLHttpRequest.cpp File Source/core/xml/XMLHttpRequest.cpp (right): https://codereview.chromium.org/455303002/diff/240001/Source/core/xml/XMLHttpRequest.cpp#newcode133 Source/core/xml/XMLHttpRequest.cpp:133: UnderlyingSource::trace(visitor); I recommend to call UnderlayingSource::trace at the ...
6 years, 4 months ago (2014-08-18 05:26:17 UTC) #11
yhirano
https://codereview.chromium.org/455303002/diff/240001/Source/core/xml/XMLHttpRequest.cpp File Source/core/xml/XMLHttpRequest.cpp (right): https://codereview.chromium.org/455303002/diff/240001/Source/core/xml/XMLHttpRequest.cpp#newcode133 Source/core/xml/XMLHttpRequest.cpp:133: UnderlyingSource::trace(visitor); On 2014/08/18 05:26:17, tkent wrote: > I recommend ...
6 years, 4 months ago (2014-08-18 05:32:38 UTC) #12
yhirano
The CQ bit was checked by yhirano@chromium.org
6 years, 4 months ago (2014-08-18 05:32:45 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/455303002/260001
6 years, 4 months ago (2014-08-18 05:33:06 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_blink_compile_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-18 06:40:05 UTC) #15
yhirano
The CQ bit was checked by yhirano@chromium.org
6 years, 4 months ago (2014-08-18 06:47:36 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/455303002/280001
6 years, 4 months ago (2014-08-18 06:48:43 UTC) #17
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 07:54:10 UTC) #18
Message was sent while issue was closed. 
Committed patchset #15 (280001) as 180432

Powered by Google App Engine
This is Rietveld 408576698