Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 455273002: Update .exe and .dmg file error messages. (Closed)

Created:
6 years, 4 months ago by iseki
Modified:
6 years, 4 months ago
Reviewers:
yoshiki, hirono
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update .exe and .dmg file error messages. Modify error message because previous message is less information. BUG=399333 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288923

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_tasks.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
iseki
Please review it.
6 years, 4 months ago (2014-08-11 04:41:14 UTC) #1
hirono
lgtm!
6 years, 4 months ago (2014-08-11 04:57:48 UTC) #2
iseki
The CQ bit was checked by iseki@chromium.org
6 years, 4 months ago (2014-08-11 05:07:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iseki@chromium.org/455273002/1
6 years, 4 months ago (2014-08-11 05:08:47 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-11 06:21:36 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-11 06:24:44 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/3294)
6 years, 4 months ago (2014-08-11 06:24:45 UTC) #7
iseki
Please review it.
6 years, 4 months ago (2014-08-11 06:37:19 UTC) #8
yoshiki
Sorry, I missed this. LGTM
6 years, 4 months ago (2014-08-12 05:02:09 UTC) #9
iseki
On 2014/08/12 05:02:09, yoshiki wrote: > Sorry, I missed this. LGTM Thank you for your ...
6 years, 4 months ago (2014-08-12 05:05:32 UTC) #10
iseki
The CQ bit was checked by iseki@chromium.org
6 years, 4 months ago (2014-08-12 05:05:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iseki@chromium.org/455273002/1
6 years, 4 months ago (2014-08-12 05:07:21 UTC) #12
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 05:50:11 UTC) #13
Message was sent while issue was closed.
Change committed as 288923

Powered by Google App Engine
This is Rietveld 408576698