tools/clang/blink_gc_plugin/tests/heap/stubs.h - Issue 455263004: Blink GC plugin: Ensure that classes with virtual trace methods always have vtables for their left-…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/tests/heap/stubs.h

Issue 455263004: Blink GC plugin: Ensure that classes with virtual trace methods always have vtables for their left-… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: CR Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/clang/blink_gc_plugin/tests/base_class_must_define_virtual_trace.txt ('k') | tools/clang/blink_gc_plugin/tests/non_virtual_trace.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/clang/blink_gc_plugin/tests/heap/stubs.h

diff --git a/tools/clang/blink_gc_plugin/tests/heap/stubs.h b/tools/clang/blink_gc_plugin/tests/heap/stubs.h

index 37466ed7d3b7e2e60a6d87c7f520d5b4b28f8793..7d646cdf85d2b4ee01beda24ded85b5ddef541eb 100644

--- a/tools/clang/blink_gc_plugin/tests/heap/stubs.h

+++ b/tools/clang/blink_gc_plugin/tests/heap/stubs.h

@@ -216,6 +216,7 @@ public:

class GarbageCollectedMixin {

virtual void adjustAndMark(Visitor*) const = 0;

virtual bool isAlive(Visitor*) const = 0;

+ virtual void trace(Visitor*) { }

};

template<typename T>