tools/clang/blink_gc_plugin/tests/base_class_must_define_virtual_trace.cpp - Issue 455263004: Blink GC plugin: Ensure that classes with virtual trace methods always have vtables for their left-…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/tests/base_class_must_define_virtual_trace.cpp

Issue 455263004: Blink GC plugin: Ensure that classes with virtual trace methods always have vtables for their left-… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: CR Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/clang/blink_gc_plugin/tests/base_class_must_define_virtual_trace.h ('k') | tools/clang/blink_gc_plugin/tests/base_class_must_define_virtual_trace.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/clang/blink_gc_plugin/tests/base_class_must_define_virtual_trace.cpp

diff --git a/tools/clang/blink_gc_plugin/tests/non_virtual_trace.cpp b/tools/clang/blink_gc_plugin/tests/base_class_must_define_virtual_trace.cpp

similarity index 54%

copy from tools/clang/blink_gc_plugin/tests/non_virtual_trace.cpp

copy to tools/clang/blink_gc_plugin/tests/base_class_must_define_virtual_trace.cpp

index 1f6a8b546df1b469f2c558d3f54f05b7ee96ebb5..cd38ec90fa96e20bc7ad52b3ca07f688e8a1a215 100644

--- a/tools/clang/blink_gc_plugin/tests/non_virtual_trace.cpp

+++ b/tools/clang/blink_gc_plugin/tests/base_class_must_define_virtual_trace.cpp

@@ -2,17 +2,18 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-#include "non_virtual_trace.h"

+#include "base_class_must_define_virtual_trace.h"

namespace blink {

-void A::trace(Visitor* visitor)

+void PartDerived::trace(Visitor* visitor)

{

}

-void C::trace(Visitor* visitor)

+void HeapDerived::trace(Visitor* visitor)

{

- B::trace(visitor);

+ visitor->trace(m_part);

}