tools/clang/blink_gc_plugin/tests/non_virtual_trace.txt - Issue 455263004: Blink GC plugin: Ensure that classes with virtual trace methods always have vtables for their left-…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/clang/blink_gc_plugin/tests/non_virtual_trace.txt

Issue 455263004: Blink GC plugin: Ensure that classes with virtual trace methods always have vtables for their left-… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: CR Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « tools/clang/blink_gc_plugin/tests/non_virtual_trace.cpp ('k') | tools/clang/blink_gc_plugin/tests/polymorphic_class_with_non_virtual_trace.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	1 In file included from non_virtual_trace.cpp:5:

	2 ./non_virtual_trace.h:12:1: warning: [blink-gc] Left-most base class 'A' of deri ved class 'D' must define a virtual trace method.

	3 class A : public GarbageCollected<A> {

	4 ^

1 non_virtual_trace.cpp:13:1: warning: [blink-gc] Class 'C' overrides non-virtual trace of base class 'A'.	5 non_virtual_trace.cpp:13:1: warning: [blink-gc] Class 'C' overrides non-virtual trace of base class 'A'.

2 void C::trace(Visitor* visitor)	6 void C::trace(Visitor* visitor)

3 ^	7 ^

4 ./non_virtual_trace.h:14:5: note: [blink-gc] Non-virtual trace method declared h ere:	8 ./non_virtual_trace.h:14:5: note: [blink-gc] Non-virtual trace method declared h ere:

5 void trace(Visitor*);	9 void trace(Visitor*);

6 ^	10 ^

7 1 warning generated.	11 non_virtual_trace.cpp:18:1: warning: [blink-gc] Class 'D' overrides non-virtual trace of base class 'A'.

	12 void D::trace(Visitor* visitor)

	13 ^

	14 ./non_virtual_trace.h:14:5: note: [blink-gc] Non-virtual trace method declared h ere:

	15 void trace(Visitor*);

	16 ^

	17 3 warnings generated.

OLD	NEW