Sheriff-o-matic: Display snoozed failure groups in a separate stream

Tools/GardeningServer/ui/ct-unexpected-failures.html

 <!--
 Copyright 2014 The Chromium Authors. All rights reserved.
 Use of this source code is governed by a BSD-style license that can be
 found in the LICENSE file.
 -->
 
 <link rel="import" href="../bower_components/paper-button/paper-button.html">
 <link rel="import" href="../model/ct-commit-log.html">
 <link rel="import" href="../model/tree-status.html">
 <link rel="import" href="ct-failure-analyzer.html">
@@ skipping 16 matching lines @@
       ct-tree-status[state=open] {
         margin: 0;
         padding: 0;
       }
     </style>
     <ct-failure-analyzer id="analyzer" failures="{{ failures }}" builderLatestRevisions="{{ builderLatestRevisions }}"></ct-failure-analyzer>
     <ct-tree-status status="{{ treeStatuses['chromium'] }}" state="{{ treeStatuses['chromium'].status }}"></ct-tree-status>
     <ct-tree-status status="{{ treeStatuses['blink'] }}" state="{{ treeStatuses['blink'].status }}"></ct-tree-status>
     <ct-revision-details id="revisionDetails" builderLatestRevisions="{{ builderLatestRevisions }}" revisionLog="{{ revisionLog }}" tree="{{ tree }}"></ct-revision-details>
     <ct-party-time failures="{{ failures }}" tree="{{ tree }}"></ct-party-time>
-    <ct-failure-stream groups="{{ failures[tree] }}" commits="{{ revisionLog }}" tree="{{ tree }}"></ct-failure-stream>
+    <ct-failure-stream category="default" groups="{{ failures[tree] }}" commits="{{ revisionLog }}" tree="{{ tree }}"></ct-failure-stream>
+    <ct-failure-stream category="snoozed" groups="{{ failures[tree] }}" commits="{{ revisionLog }}" tree="{{ tree }}"></ct-failure-stream>

[ojan, 2014/08/11 03:43:35]

I was picturing that we'd change the model (as created by ct-failure-analyzer)
so that we have a list of failures per category and then only pass in the right
groups to each ct-failure-stream. So, we'd have failures[tree][category]. An
advantage of that approach is that it makes it easy to do the FIXME you
currently have in ct-failure-stream.

<template if="{{ failures[tree].default.length }}">
    <ct-failure-stream groups="{{ failures[tree].default }}" commits="{{
revisionLog }}" tree="{{ tree }}"></ct-failure-stream>
</template>
<template if="{{ failures[tree].snoozed.length }}">
    <h2>Snoozed failures</h2>
    <ct-failure-stream groups="{{ failures[tree].default }}" commits="{{
revisionLog }}" tree="{{ tree }}"></ct-failure-stream>
</template>

[dstockwell, 2014/08/14 23:20:33]

This would seem to complicate the model somewhat, when a failure group changes
category it needs to move between trees.

I don't think that the failure-group should be responsible for changing its
container, which would likely mean we need to introduce a model object to
represent failures for a given tree -- that could monitor (via observe) the
categories of its child failure groups and move them between category buckets.
WDYT?

   </template>
   <script>
   (function() {
     // FIXME: Make the update frequency 30 seconds again once we fix crbug.com/401358.
     var kUpdateFrequency = 1000 * 30 * 10;
 
     Polymer({
       revisionLog: new CTCommitLog(),
       tree: '',
 
@@ skipping 16 matching lines @@
         this.revisionLog.update();
         this.$.analyzer.update();
         Object.keys(this.treeStatuses, function(tree, status) {
           status.update();
         });
       },
     });
   })();
   </script>
 </polymer-element>