Source/core/rendering/RenderTheme.cpp - Issue 455223002: Make anchors mouse-focusable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderTheme.cpp

Issue 455223002: Make anchors mouse-focusable (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: De-duplicate using FocusController; update TestExpectations Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderTheme.cpp

diff --git a/Source/core/rendering/RenderTheme.cpp b/Source/core/rendering/RenderTheme.cpp

index 2111f2fb8126f8346395abdc902d7c748e674ba1..b04068a4c2666fd257071ef1fef93da794b401c1 100644

--- a/Source/core/rendering/RenderTheme.cpp

+++ b/Source/core/rendering/RenderTheme.cpp

@@ -600,11 +600,11 @@ bool RenderTheme::shouldDrawDefaultFocusRing(RenderObject* renderer) const

{

if (supportsFocusRing(renderer->style()))

return false;

- if (!renderer->style()->hasAppearance())

- return true;

Node* node = renderer->node();

if (!node)

return true;

+ if (!renderer->style()->hasAppearance() && !node->isLink())

+ return true;

// We can't use RenderTheme::isFocused because outline:auto might be

// specified to non-:focus rulesets.

if (node->focused() && !node->shouldHaveFocusAppearance())