Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1597)

Unified Diff: Source/core/svg/SVGAElement.cpp

Issue 455223002: Make anchors mouse-focusable (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Move m_wasFocusedByMouse into subclasses. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGAElement.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGAElement.cpp
diff --git a/Source/core/svg/SVGAElement.cpp b/Source/core/svg/SVGAElement.cpp
index 7cb84f81f84681390520a21c97e0d0a3f474d8cf..21b8f123a9ef95aec128c69e4e9c6fb817276dcf 100644
--- a/Source/core/svg/SVGAElement.cpp
+++ b/Source/core/svg/SVGAElement.cpp
@@ -57,6 +57,7 @@ inline SVGAElement::SVGAElement(Document& document)
: SVGGraphicsElement(SVGNames::aTag, document)
, SVGURIReference(this)
, m_svgTarget(SVGAnimatedString::create(this, SVGNames::targetAttr, SVGString::create()))
+ , m_wasFocusedByMouse(false)
{
ScriptWrappable::init(this);
addToPropertyMap(m_svgTarget);
@@ -157,7 +158,22 @@ bool SVGAElement::supportsFocus() const
if (hasEditableStyle())
return SVGGraphicsElement::supportsFocus();
// If not a link we should still be able to focus the element if it has tabIndex.
- return isLink() || Element::supportsFocus();
+ return isLink() || SVGGraphicsElement::supportsFocus();
+}
+
+bool SVGAElement::shouldHaveFocusAppearance() const
+{
+ return !m_wasFocusedByMouse || SVGGraphicsElement::supportsFocus();
+}
+
+bool SVGAElement::wasFocusedByMouse() const
+{
+ return m_wasFocusedByMouse;
+}
+
+void SVGAElement::setWasFocusedByMouse(bool wasFocusedByMouse)
+{
+ m_wasFocusedByMouse = wasFocusedByMouse;
}
bool SVGAElement::isURLAttribute(const Attribute& attribute) const
@@ -167,10 +183,8 @@ bool SVGAElement::isURLAttribute(const Attribute& attribute) const
bool SVGAElement::isMouseFocusable() const
{
- // Links are focusable by default, but only allow links with tabindex or contenteditable to be mouse focusable.
- // https://bugs.webkit.org/show_bug.cgi?id=26856
if (isLink())
- return Element::supportsFocus();
+ return supportsFocus();
return SVGElement::isMouseFocusable();
}
« no previous file with comments | « Source/core/svg/SVGAElement.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698