Source/core/html/HTMLFormControlElement.h - Issue 455223002: Make anchors mouse-focusable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLFormControlElement.h

Issue 455223002: Make anchors mouse-focusable (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Move m_wasFocusedByMouse to elementData().m_shouldHideFocusRingOnMouseFocus Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLFormControlElement.h

diff --git a/Source/core/html/HTMLFormControlElement.h b/Source/core/html/HTMLFormControlElement.h

index 055bcd14f17a3a3d0305993c7a63263f902ab510..3185317dac296ce7f0443bf33068153060df0c51 100644

--- a/Source/core/html/HTMLFormControlElement.h

+++ b/Source/core/html/HTMLFormControlElement.h

@@ -128,11 +128,8 @@ protected:

virtual bool supportsFocus() const OVERRIDE;

virtual bool isKeyboardFocusable() const OVERRIDE;

- virtual bool shouldShowFocusRingOnMouseFocus() const;

- virtual bool shouldHaveFocusAppearance() const OVERRIDE FINAL;

- virtual void dispatchFocusEvent(Element* oldFocusedElement, FocusType) OVERRIDE;

+ virtual bool shouldShowFocusRingOnMouseFocus() const OVERRIDE;

virtual void dispatchBlurEvent(Element* newFocusedElement) OVERRIDE;

- virtual void willCallDefaultEventHandler(const Event&) OVERRIDE FINAL;

virtual void didRecalcStyle(StyleRecalcChange) OVERRIDE FINAL;

@@ -183,7 +180,6 @@ private:

bool m_isValid : 1;

bool m_wasChangedSinceLastFormControlChangeEvent : 1;

- bool m_wasFocusedByMouse : 1;

};

inline bool isHTMLFormControlElement(const Element& element)