Make anchors mouse-focusable

Source/core/svg/SVGAElement.cpp

 /*
  * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2004, 2005, 2007 Rob Buis <buis@kde.org>
  * Copyright (C) 2007 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2010 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 23 matching lines @@
 #include "core/frame/FrameHost.h"
 #include "core/frame/LocalFrame.h"
 #include "core/html/HTMLAnchorElement.h"
 #include "core/html/HTMLFormElement.h"
 #include "core/html/parser/HTMLParserIdioms.h"
 #include "core/loader/FrameLoadRequest.h"
 #include "core/loader/FrameLoader.h"
 #include "core/loader/FrameLoaderTypes.h"
 #include "core/page/Chrome.h"
 #include "core/page/ChromeClient.h"
+#include "core/page/FocusController.h"
 #include "core/page/Page.h"
 #include "core/rendering/svg/RenderSVGInline.h"
 #include "core/rendering/svg/RenderSVGText.h"
 #include "core/rendering/svg/RenderSVGTransformableContainer.h"
 #include "core/svg/animation/SVGSMILElement.h"
 #include "platform/PlatformMouseEvent.h"
 #include "platform/network/ResourceRequest.h"
 
 namespace blink {
 
@@ skipping 96 matching lines @@
 {
     // Skip the supportsFocus check in SVGElement.
     return Element::tabIndex();
 }
 
 bool SVGAElement::supportsFocus() const
 {
     if (hasEditableStyle())
         return SVGGraphicsElement::supportsFocus();
     // If not a link we should still be able to focus the element if it has tabIndex.
-    return isLink() || Element::supportsFocus();
+    return isLink() || SVGGraphicsElement::supportsFocus();
+}
+
+bool SVGAElement::shouldHaveFocusAppearance() const
+{
+    ASSERT(focused());
+    return !document().page()->focusController().wasFocusedByMouse() || SVGGraphicsElement::supportsFocus();

[pdr., 2014/08/12 02:02:23]

Why is this SVGGraphicsElement::supportsFocus instead of just supportsFocus()?

[robwu, 2014/08/12 14:27:49]

I noticed that the HTMLAnchorElement refers to HTMLElement::supportsFocus, so
for symmetry I also uses SVGAElement::supportsFocus in SVGAElement, to make sure
that any SVG-specific additions to supportFocus are also applied to the SVG <a>
element.

 }
 
 bool SVGAElement::isURLAttribute(const Attribute& attribute) const
 {
     return attribute.name().localName() == hrefAttr || SVGGraphicsElement::isURLAttribute(attribute);
 }
 
 bool SVGAElement::isMouseFocusable() const
 {
-    // Links are focusable by default, but only allow links with tabindex or contenteditable to be mouse focusable.
-    // https://bugs.webkit.org/show_bug.cgi?id=26856
     if (isLink())
-        return Element::supportsFocus();
+        return supportsFocus();
 
     return SVGElement::isMouseFocusable();
 }
 
 bool SVGAElement::isKeyboardFocusable() const
 {
     if (isFocusable() && Element::supportsFocus())
         return SVGElement::isKeyboardFocusable();
 
     if (isLink())
         return document().frameHost()->chrome().client().tabsToLinks();
     return SVGElement::isKeyboardFocusable();
 }
 
 bool SVGAElement::canStartSelection() const
 {
     if (!isLink())
         return SVGElement::canStartSelection();
     return hasEditableStyle();
 }
 
 bool SVGAElement::willRespondToMouseClickEvents()
 {
     return isLink() || SVGGraphicsElement::willRespondToMouseClickEvents();
 }
 
 } // namespace blink