LayoutTests/fast/events/resources/focus-anchor-by-mouse.js - Issue 455223002: Make anchors mouse-focusable - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(259)

My Issues | Starred Open | Closed | All

Side by Side Diff: LayoutTests/fast/events/resources/focus-anchor-by-mouse.js

Issue 455223002: Make anchors mouse-focusable (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: De-duplicate using FocusController; update TestExpectations Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/fast/events/click-focus-svganchor-has-ring.html ('K') | « LayoutTests/fast/events/click-focus-svganchor-no-ring.html ('k') | Source/core/dom/Node.h » ('j') | Source/core/dom/Node.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 var aElement = document.getElementById('anchor');

	2 eventSender.mouseMoveTo(aElement.offsetLeft + 2, aElement.offsetTop + 2);

	3 eventSender.mouseDown();

	4

	5 testRunner.dumpAsTextWithPixelResults();
	pdr. 2014/08/12 02:02:22 I don't think we need any pixel tests are needed h I don't think we need any pixel tests are needed here. For your reftest expectation files, just explicitly call focus() on it and the focus ring will be drawn. robwu 2014/08/12 14:27:49 I cannot think of any other method besides pixel t Show quoted text On 2014/08/12 02:02:22, pdr wrote: > I don't think we need any pixel tests are needed here. For your reftest > expectation files, just explicitly call focus() on it and the focus ring will be > drawn. I cannot think of any other method besides pixel tests to verify that a focus ring is drawn when needed, and not drawn when not needed. robwu 2014/08/15 22:51:33 I've replaced the pixel tests with ref tests, and Show quoted text On 2014/08/12 02:02:22, pdr wrote: > I don't think we need any pixel tests are needed here. For your reftest > expectation files, just explicitly call focus() on it and the focus ring will be > drawn. I've replaced the pixel tests with ref tests, and added focus tests for SVG. WDYT now?
OLD	NEW

« LayoutTests/fast/events/click-focus-svganchor-has-ring.html ('K') | « LayoutTests/fast/events/click-focus-svganchor-no-ring.html ('k') | Source/core/dom/Node.h » ('j') | Source/core/dom/Node.cpp » ('J')

Powered by Google App Engine

This is Rietveld 408576698