Make anchors mouse-focusable

Source/core/dom/Element.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Peter Kelly (pmk@post.com)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2003-2011, 2013, 2014 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 353 matching lines @@
     virtual Image* imageContents() { return 0; }
 
     virtual void focus(bool restorePreviousSelection = true, FocusType = FocusTypeNone);
     virtual void updateFocusAppearance(bool restorePreviousSelection);
     virtual void blur();
     // Whether this element can receive focus at all. Most elements are not
     // focusable but some elements, such as form controls and links, are. Unlike
     // rendererIsFocusable(), this method may be called when layout is not up to
     // date, so it must not use the renderer to determine focusability.
     virtual bool supportsFocus() const;
+    virtual bool shouldShowFocusRingOnMouseFocus() const { return true; };
+    virtual bool shouldHaveFocusAppearance() const OVERRIDE FINAL;
     // Whether the node can actually be focused.
     bool isFocusable() const;
     virtual bool isKeyboardFocusable() const;
     virtual bool isMouseFocusable() const;
+    virtual void willCallDefaultEventHandler(const Event&) OVERRIDE FINAL;
     virtual void dispatchFocusEvent(Element* oldFocusedElement, FocusType);
     virtual void dispatchBlurEvent(Element* newFocusedElement);
     void dispatchFocusInEvent(const AtomicString& eventType, Element* oldFocusedElement);
     void dispatchFocusOutEvent(const AtomicString& eventType, Element* newFocusedElement);
 
     String innerText();
     String outerText();
     String innerHTML() const;
     String outerHTML() const;
     void setInnerHTML(const String&, ExceptionState&);
@@ skipping 242 matching lines @@
     ElementRareData& ensureElementRareData();
 
     WillBeHeapVector<RefPtrWillBeMember<Attr> >& ensureAttrNodeList();
     void removeAttrNodeList();
     void detachAllAttrNodesFromElement();
     void detachAttrNodeFromElementWithValue(Attr*, const AtomicString& value);
     void detachAttrNodeAtIndex(Attr*, size_t index);
 
     bool isJavaScriptURLAttribute(const Attribute&) const;
 
+    bool m_wasFocusedByMouse;

[pdr., 2014/08/25 17:46:18]

Should this be put in m_elementData instead?

[robwu, 2014/08/25 22:40:03]

Probably yes. I found it a bit odd that there were so little members in the
Element class. I've just moved this property to elementData(), and on the way
renamed it. To prevent creating unnecessary UniqueElementData objects, the new
member is only set when the element supports optional focus rings.

Could you review my newest patch set?

+
     RefPtrWillBeMember<ElementData> m_elementData;
 };
 
 DEFINE_NODE_TYPE_CASTS(Element, isElementNode());
 template <typename T> bool isElementOfType(const Node&);
 template <> inline bool isElementOfType<const Element>(const Node& node) { return node.isElementNode(); }
 template <typename T> inline bool isElementOfType(const Element& element) { return isElementOfType<T>(static_cast<const Node&>(element)); }
 template <> inline bool isElementOfType<const Element>(const Element&) { return true; }
 
 // Type casting.
@@ skipping 201 matching lines @@
     static PassRefPtrWillBeRawPtr<T> create(const QualifiedName&, Document&)
 #define DEFINE_ELEMENT_FACTORY_WITH_TAGNAME(T) \
     PassRefPtrWillBeRawPtr<T> T::create(const QualifiedName& tagName, Document& document) \
     { \
         return adoptRefWillBeNoop(new T(tagName, document)); \
     }
 
 } // namespace
 
 #endif