Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 455213002: use new onDrawPicture variant (Closed)

Created:
6 years, 4 months ago by reed2
Modified:
6 years, 4 months ago
Reviewers:
CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

use new onDrawPicture variant, as the previous is now deprecated and is no longer called by the base-class. TBR=fmalita@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179891

Patch Set 1 #

Patch Set 2 : update InterceptingCanvas #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -23 lines) Patch
M Source/platform/graphics/InterceptingCanvas.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/LoggingCanvas.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/graphics/LoggingCanvas.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/platform/graphics/ProfilingCanvas.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/graphics/ProfilingCanvas.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/platform/graphics/ReplayingCanvas.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/graphics/ReplayingCanvas.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
reed2
The CQ bit was checked by reed@chromium.org
6 years, 4 months ago (2014-08-10 12:34:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@chromium.org/455213002/1
6 years, 4 months ago (2014-08-10 12:35:03 UTC) #2
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_blink_compile_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-10 12:53:44 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-10 12:56:53 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/19161)
6 years, 4 months ago (2014-08-10 12:56:55 UTC) #5
reed2
The CQ bit was checked by reed@chromium.org
6 years, 4 months ago (2014-08-10 13:21:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@chromium.org/455213002/20001
6 years, 4 months ago (2014-08-10 13:22:02 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-10 14:16:58 UTC) #8
Message was sent while issue was closed.
Change committed as 179891

Powered by Google App Engine
This is Rietveld 408576698