Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Unified Diff: tools/gn/ninja_build_writer.h

Issue 455193003: GN: Generate error if multiple rules generate same file (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/command_gen.cc ('k') | tools/gn/ninja_build_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_build_writer.h
diff --git a/tools/gn/ninja_build_writer.h b/tools/gn/ninja_build_writer.h
index 1de6719ede224bc204dad3840380ed83a1cdfcaf..427b54e54ddac84c7f03d2286e334823d73e9ab3 100644
--- a/tools/gn/ninja_build_writer.h
+++ b/tools/gn/ninja_build_writer.h
@@ -11,6 +11,7 @@
#include "tools/gn/path_output.h"
class BuildSettings;
+class Err;
class Settings;
class Target;
class Toolchain;
@@ -24,7 +25,8 @@ class NinjaBuildWriter {
const BuildSettings* settings,
const std::vector<const Settings*>& all_settings,
const Toolchain* default_toolchain,
- const std::vector<const Target*>& default_toolchain_targets);
+ const std::vector<const Target*>& default_toolchain_targets,
+ Err* err);
private:
NinjaBuildWriter(const BuildSettings* settings,
@@ -35,12 +37,12 @@ class NinjaBuildWriter {
std::ostream& dep_out);
~NinjaBuildWriter();
- void Run();
+ bool Run(Err* err);
void WriteNinjaRules();
void WriteLinkPool();
void WriteSubninjas();
- void WritePhonyAndAllRules();
+ bool WritePhonyAndAllRules(Err* err);
void WritePhonyRule(const Target* target, const OutputFile& target_file,
const std::string& phony_name);
« no previous file with comments | « tools/gn/command_gen.cc ('k') | tools/gn/ninja_build_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698