tools/gn/ninja_build_writer.h - Issue 455193003: GN: Generate error if multiple rules generate same file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/ninja_build_writer.h

Issue 455193003: GN: Generate error if multiple rules generate same file (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Just check outputs when producing final ninja file Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/ninja_build_writer.h

diff --git a/tools/gn/ninja_build_writer.h b/tools/gn/ninja_build_writer.h

index 1de6719ede224bc204dad3840380ed83a1cdfcaf..86197e85ff43bd1324b9f87a0a51d24b7c68c5f6 100644

--- a/tools/gn/ninja_build_writer.h

+++ b/tools/gn/ninja_build_writer.h

@@ -35,12 +35,12 @@ class NinjaBuildWriter {

std::ostream& dep_out);

~NinjaBuildWriter();

- void Run();

+ bool Run();

void WriteNinjaRules();

void WriteLinkPool();

void WriteSubninjas();

- void WritePhonyAndAllRules();

+ bool WritePhonyAndAllRules();

void WritePhonyRule(const Target* target, const OutputFile& target_file,

const std::string& phony_name);

« no previous file with comments | « no previous file | tools/gn/ninja_build_writer.cc » ('j') | tools/gn/ninja_build_writer.cc » ('J')