Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 455193002: XMLHttpRequest: Factor out decorder/document init (Closed)

Created:
6 years, 4 months ago by kouhei (in TOK)
Modified:
6 years, 4 months ago
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

XMLHttpRequest: Factor out decorder/document init - |m_createdDocument| renamed to |m_parsedResponse| - Refactor |didReceiveResponse|: -- Decoder init factored out into |createDecoder| - Refactor |responseXML|: -- Response document init factored out into |initResponseDocument| Refactoring in preperation to async parsing change. This patch is split from https://codereview.chromium.org/454313002/ TEST=fast/xmlhttprequest, http/tests/xmlhttprequest BUG=402261 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179894

Patch Set 1 #

Total comments: 2

Patch Set 2 : braces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -47 lines) Patch
M Source/core/xml/XMLHttpRequest.h View 2 chunks +4 lines, -1 line 0 comments Download
M Source/core/xml/XMLHttpRequest.cpp View 1 6 chunks +65 lines, -46 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
kouhei (in TOK)
Would you take a look?
6 years, 4 months ago (2014-08-10 02:52:50 UTC) #1
abarth-chromium
lgtm https://codereview.chromium.org/455193002/diff/1/Source/core/xml/XMLHttpRequest.cpp File Source/core/xml/XMLHttpRequest.cpp (right): https://codereview.chromium.org/455193002/diff/1/Source/core/xml/XMLHttpRequest.cpp#newcode1280 Source/core/xml/XMLHttpRequest.cpp:1280: } No need for { }
6 years, 4 months ago (2014-08-10 04:49:24 UTC) #2
kouhei (in TOK)
Thanks for review! https://codereview.chromium.org/455193002/diff/1/Source/core/xml/XMLHttpRequest.cpp File Source/core/xml/XMLHttpRequest.cpp (right): https://codereview.chromium.org/455193002/diff/1/Source/core/xml/XMLHttpRequest.cpp#newcode1280 Source/core/xml/XMLHttpRequest.cpp:1280: } On 2014/08/10 04:49:24, abarth wrote: ...
6 years, 4 months ago (2014-08-10 15:40:15 UTC) #3
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 4 months ago (2014-08-10 15:40:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/455193002/20001
6 years, 4 months ago (2014-08-10 15:40:40 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-10 16:35:07 UTC) #6
commit-bot: I haz the power
Change committed as 179894
6 years, 4 months ago (2014-08-10 17:06:35 UTC) #7
tyoshino (SeeGerritForStatus)
6 years, 4 months ago (2014-08-11 13:20:13 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698