Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 455073004: Switch DesktopEnvironment to return a DesktopCapturer. (Closed)

Created:
6 years, 4 months ago by Wez
Modified:
6 years, 4 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chromoting-reviews_chromium.org, ronakvora do not use
Project:
chromium
Visibility:
Public.

Description

Switch DesktopEnvironment to return a DesktopCapturer. This removes the need for a lot of additional boilerplate in proxying capturer implementations, and makes it possible to implement DesktopEnvironment using any kind of DesktopCapturer, e.g. ScreenCapturer or WindowCapturer, for example. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289020

Patch Set 1 #

Patch Set 2 : Fix unit tests and mocks. #

Patch Set 3 : Rename FakeScreenCapturer and ShapedScreenCapturer #

Patch Set 4 : Remove ShapedDesktopCapturer::Create() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+247 lines, -637 lines) Patch
M remoting/host/basic_desktop_environment.h View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/basic_desktop_environment.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/chromoting_host.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/chromoting_host_unittest.cc View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M remoting/host/client_session.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M remoting/host/client_session_unittest.cc View 1 2 5 chunks +8 lines, -8 lines 0 comments Download
M remoting/host/desktop_environment.h View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/desktop_process_unittest.cc View 1 2 4 chunks +6 lines, -6 lines 0 comments Download
M remoting/host/desktop_session_agent.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/desktop_session_agent.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/desktop_session_proxy.h View 3 chunks +2 lines, -3 lines 0 comments Download
M remoting/host/desktop_session_proxy.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + remoting/host/fake_desktop_capturer.h View 1 2 2 chunks +12 lines, -19 lines 0 comments Download
A + remoting/host/fake_desktop_capturer.cc View 1 2 6 chunks +12 lines, -30 lines 0 comments Download
M remoting/host/fake_desktop_environment.h View 1 2 3 6 chunks +10 lines, -8 lines 0 comments Download
M remoting/host/fake_desktop_environment.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M remoting/host/fake_host_extension.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
D remoting/host/fake_screen_capturer.h View 1 2 1 chunk +0 lines, -57 lines 0 comments Download
D remoting/host/fake_screen_capturer.cc View 1 2 1 chunk +0 lines, -169 lines 0 comments Download
M remoting/host/host_extension_session.h View 3 chunks +3 lines, -4 lines 0 comments Download
M remoting/host/host_extension_session.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/host/host_extension_session_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/host/host_extension_session_manager.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/host/host_extension_session_manager_unittest.cc View 1 3 chunks +5 lines, -3 lines 0 comments Download
M remoting/host/host_mock_objects.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/host_mock_objects.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/host/ipc_desktop_environment.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/ipc_desktop_environment.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/ipc_desktop_environment_unittest.cc View 1 2 13 chunks +16 lines, -16 lines 0 comments Download
M remoting/host/ipc_video_frame_capturer.h View 1 2 2 chunks +5 lines, -22 lines 0 comments Download
M remoting/host/ipc_video_frame_capturer.cc View 3 chunks +0 lines, -24 lines 0 comments Download
A remoting/host/shaped_desktop_capturer.h View 1 2 3 1 chunk +41 lines, -0 lines 0 comments Download
A remoting/host/shaped_desktop_capturer.cc View 1 2 3 1 chunk +42 lines, -0 lines 0 comments Download
A + remoting/host/shaped_desktop_capturer_unittest.cc View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
D remoting/host/shaped_screen_capturer.h View 1 2 1 chunk +0 lines, -48 lines 0 comments Download
D remoting/host/shaped_screen_capturer.cc View 1 2 1 chunk +0 lines, -67 lines 0 comments Download
D remoting/host/shaped_screen_capturer_unittest.cc View 1 2 1 chunk +0 lines, -70 lines 0 comments Download
M remoting/host/video_scheduler.h View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M remoting/host/video_scheduler.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/video_scheduler_unittest.cc View 1 2 8 chunks +17 lines, -15 lines 0 comments Download
M remoting/remoting_host.gypi View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/remoting_test.gypi View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M remoting/test/protocol_perftest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Wez
6 years, 4 months ago (2014-08-11 06:41:56 UTC) #1
Wez
Jamie, can you take a look?
6 years, 4 months ago (2014-08-11 19:10:16 UTC) #2
Wez
Sergey: Ping :)
6 years, 4 months ago (2014-08-12 16:52:00 UTC) #3
Sergey Ulanov
LGTM. Thanks!
6 years, 4 months ago (2014-08-12 17:13:01 UTC) #4
Wez
The CQ bit was checked by wez@chromium.org
6 years, 4 months ago (2014-08-12 17:16:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/455073004/60001
6 years, 4 months ago (2014-08-12 17:20:49 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 18:04:45 UTC) #7
Message was sent while issue was closed.
Change committed as 289020

Powered by Google App Engine
This is Rietveld 408576698