Issue 455063002: Fix autosize related bugs in <extensionoptions>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 455063002: Fix autosize related bugs in <extensionoptions> (Closed)

Created:
6 years, 4 months ago by ericzeng

Modified:
6 years, 4 months ago

Reviewers:
Fady Samuel, not at google - send to devlin

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Fix autosize related bugs in <extensionoptions> Remove an extraneous call to GuestViewInternal.setAutoSize in attachWindow, fix an uninitialized variable BUG=386838 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288525

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -13 lines)			Patch
	M	chrome/browser/guest_view/extension_options/extension_options_guest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/renderer/resources/extensions/extension_options.js	View		1 chunk	+0 lines, -12 lines	0 comments	Download

Total messages: 8 (0 generated)

ericzeng

On 2014/08/08 22:16:54, kalman wrote: > (how did you notice this?) Fady brought it up

6 years, 4 months ago (2014-08-08 22:21:15 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericzeng@chromium.org/455063002/1

6 years, 4 months ago (2014-08-08 22:23:50 UTC) #7

Message was sent while issue was closed.

Change committed as 288525