use conics

use conics

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/220f926d9d4b38a9018c922c095847bbd261f583

[reed1, 2014-12-16 21:22:01]

reed@google.com changed reviewers:
+ bsalomon@google.com, caryclark@google.com, egdaniel@google.com,
joshualitt@google.com

[reed1, 2014-12-16 21:22:01]

Lots of tiny rebaseline diffs, but a couple of real failures:

gpu/path-reverse
gpu/circular-clips

[reed1, 2014-12-17 15:13:28]

I've disabled the actual motivating change : upgrading addOval() to use conics,
until we can fix the gpu bugs.

However, this change should still land, as it prepares the way (nearly).

This triggers some rebaselines even still, but these are all related to
perspective (where I correctly turn quads into conics). Blink never uses this,
so I don't expect any hit on the DEPS roll.

PTAL

[reed1, 2014-12-17 15:13:34]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-12-17 15:14:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/455043002/40001

[commit-bot: I haz the power, 2014-12-17 15:14:31]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2014-12-17 21:14 UTC

[commit-bot: I haz the power, 2014-12-17 15:16:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-17 15:16:00]

Try jobs failed on following builders:
  Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot on client.skia.compile
(http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GC...)

[reed1, 2014-12-17 15:34:30]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-12-17 15:35:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/455043002/60001

[commit-bot: I haz the power, 2014-12-17 15:35:27]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2014-12-17 21:35 UTC

[reed1, 2014-12-17 15:35:58]

The CQ bit was unchecked by reed@google.com

[caryclark, 2014-12-17 15:52:44]

lgtm

https://codereview.chromium.org/455043002/diff/60001/src/core/SkGeometry.cpp
File src/core/SkGeometry.cpp (right):

https://codereview.chromium.org/455043002/diff/60001/src/core/SkGeometry.cpp#...
src/core/SkGeometry.cpp:1549: matrix.mapHomogeneousPoints((SkScalar*)dst, (const
SkScalar*)src, 3);
&dst[0].fX, &src[0].fX would avoid the cast..

https://codereview.chromium.org/455043002/diff/60001/src/core/SkGeometry.h
File src/core/SkGeometry.h (right):

https://codereview.chromium.org/455043002/diff/60001/src/core/SkGeometry.h#ne...
src/core/SkGeometry.h:239: memcpy(fPts, pts, 3 * sizeof(SkPoint));
use sizeof(fPts) instead?

https://codereview.chromium.org/455043002/diff/60001/src/core/SkPath.cpp
File src/core/SkPath.cpp (right):

https://codereview.chromium.org/455043002/diff/60001/src/core/SkPath.cpp#newc...
src/core/SkPath.cpp:236: static inline void SkCheck(bool predicate) {
Is this different from SK_ALWAYSBREAK() ?

[bsalomon, 2014-12-17 16:00:27]

https://codereview.chromium.org/455043002/diff/60001/src/core/SkPath.cpp
File src/core/SkPath.cpp (right):

https://codereview.chromium.org/455043002/diff/60001/src/core/SkPath.cpp#newc...
src/core/SkPath.cpp:236: static inline void SkCheck(bool predicate) {
On 2014/12/17 15:52:43, caryclark wrote:
> Is this different from SK_ALWAYSBREAK() ?

Seems weird to have this one-off here. Can this be separated out?

[reed1, 2014-12-17 16:12:38]

https://codereview.chromium.org/455043002/diff/60001/src/core/SkGeometry.h
File src/core/SkGeometry.h (right):

https://codereview.chromium.org/455043002/diff/60001/src/core/SkGeometry.h#ne...
src/core/SkGeometry.h:239: memcpy(fPts, pts, 3 * sizeof(SkPoint));
On 2014/12/17 15:52:43, caryclark wrote:
> use sizeof(fPts) instead?

Done.

https://codereview.chromium.org/455043002/diff/60001/src/core/SkPath.cpp
File src/core/SkPath.cpp (right):

https://codereview.chromium.org/455043002/diff/60001/src/core/SkPath.cpp#newc...
src/core/SkPath.cpp:236: static inline void SkCheck(bool predicate) {
On 2014/12/17 16:00:26, bsalomon wrote:
> On 2014/12/17 15:52:43, caryclark wrote:
> > Is this different from SK_ALWAYSBREAK() ?
> 
> Seems weird to have this one-off here. Can this be separated out?

Will replace with ALWAYSBREAK, and propose the new name convention separately (I
NEVER remember that ALWAYSBREAK doesn't do it always, but is actually performing
a check).

[reed1, 2014-12-17 16:12:44]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-12-17 16:12:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/455043002/80001

[commit-bot: I haz the power, 2014-12-17 16:21:10]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/220f926d9d4b38a9018c922c095847bbd261f583