Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: sync/internal_api/sync_backup_manager.cc

Issue 455023003: Let SyncBackupManager keep backup data in memory until shutdown. Only persist (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix sync manager test Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/internal_api/sync_backup_manager.h ('k') | sync/internal_api/sync_backup_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/internal_api/sync_backup_manager.cc
diff --git a/sync/internal_api/sync_backup_manager.cc b/sync/internal_api/sync_backup_manager.cc
index be8b8720044248a403e928205334745f7d9bacfa..d626229dfc2760cdf888eda04c1b599d0c0ee335 100644
--- a/sync/internal_api/sync_backup_manager.cc
+++ b/sync/internal_api/sync_backup_manager.cc
@@ -23,6 +23,7 @@ void SyncBackupManager::Init(InitArgs* args) {
if (SyncRollbackManagerBase::InitInternal(
args->database_location,
args->internal_components_factory.get(),
+ InternalComponentsFactory::STORAGE_ON_DISK_DEFERRED,
args->unrecoverable_error_handler.Pass(),
args->report_unrecoverable_error_function)) {
GetUserShare()->directory->CollectMetaHandleCounts(
@@ -34,10 +35,8 @@ void SyncBackupManager::Init(InitArgs* args) {
}
void SyncBackupManager::SaveChanges() {
- if (initialized()) {
+ if (initialized())
NormalizeEntries();
- GetUserShare()->directory->SaveChanges();
- }
}
SyncStatus SyncBackupManager::GetDetailedStatus() const {
@@ -122,6 +121,15 @@ void SyncBackupManager::HideSyncPreference(ModelType type) {
}
}
+void SyncBackupManager::ShutdownOnSyncThread(ShutdownReason reason) {
+ if (reason == SWITCH_MODE_SYNC) {
+ NormalizeEntries();
+ GetUserShare()->directory->SaveChanges();
+ }
+
+ SyncRollbackManagerBase::ShutdownOnSyncThread(reason);
+}
+
void SyncBackupManager::RegisterDirectoryTypeDebugInfoObserver(
syncer::TypeDebugInfoObserver* observer) {}
« no previous file with comments | « sync/internal_api/sync_backup_manager.h ('k') | sync/internal_api/sync_backup_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698